DataGrd: Use VisualBrush to generate DragIndicator if Header is a Control. #18154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rabbitism
changed the title
|
You can test this PR using the following package version. |
maxkatz6
approved these changes
Feb 15, 2025
maxkatz6
added
bug
area-datagrid
backport-candidate-11.2.x
maxkatz6
added
backported-11.2.x
and removed
backport-candidate-11.2.x
maxkatz6
pushed a commit
that referenced
this pull request
Feb 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
Reusing DataGridColumnHeader content to generate indicator will trigger visual tree exception if content is a control. This PR use similar approach as ComboBox to generate a rectangle with visual brush to avoid this issue.
What is the current behavior?
When column header is a control, reordering the column will crash app with exception
Control XX already has a visual parentWhat is the updated/expected behavior with this PR?
Can drag as expected.
How was the solution implemented (if it's not obvious)?
Same as how ComboBox generates SelectionBoxItem.
Checklist
Breaking changes
Obsoletions / Deprecations
Fixed issues