[ScrollViewerPresenter] Fix rtl scroll (#16667) #17714
Conversation
|
You can test this PR using the following package version. |
|
@maxkatz6 Any updates? |
|
You can test this PR using the following package version. |
|
|
||
| else | ||
| { | ||
| delta = AdjustDeltaForFlowDirection(delta, FlowDirection); |
There was a problem hiding this comment.
This should be done unconditionally, not in an else block. Otherwise, shift + scroll wheel is still reversed.
There was a problem hiding this comment.
I am not sure about this. I think shift+scroll should remained the original behavior, as scrolling up means to show later content. Maybe ask some native Arabic speakers' opinion like @Mop1398
There was a problem hiding this comment.
Afaict, at least on browsers, shift+wheel up scrolls left even with direction: rtl.
But I'm no expert here, let's wait for a native speaker's input.
There was a problem hiding this comment.
Note: I've searched for, but couldn't find any other behavior than Shift+Left scrolling Up and Shift+Right scrolling Down, whatever the text direction.
I don't want to hold this PR, as the original issue is fixed. I'm going to merge it. We can revisit the Shift+Left/Right scrolling in another issue if needed.
MrJul
added
the
backport-candidate-11.2.x
maxkatz6
added
backported-11.2.x
and removed
backport-candidate-11.2.x
* Fix rtl scroll (#16667) * fix shift + scroll --------- Co-authored-by: ijklam <[email protected]>
What does the pull request do?
Make
ScrollViewerPresenterhorizontal scroll more natural whenFlowDirectionset toRightToLeft.Fix #16667.
What is the current behavior?
When
FlowDirectionset toRightToLeft, swiping from right to left will move the left-hand-side content to the right.default.mp4
What is the updated/expected behavior with this PR?
When
FlowDirectionset toRightToLeft, swiping from right to left should move the right-hand-side content to the left.default.mp4
Checklist
Fixed issues
Fix #16667.