DropShadowDirectionEffect: add AffectsRender for ShadowDepthProperty and DirectionProperty #17664
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can test this PR using the following package version. |
|
maxkatz6
approved these changes
Dec 2, 2024
@cla-avalonia agree |
|
@cla-avalonia agree |
|
You can test this PR using the following package version. |
kekekeks
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
Fixed an issue that value change on
DepthandDirectionwill not trigger the re-render for the shadowWhat is the current behavior?
Now the changes will affect the render
What is the updated/expected behavior with this PR?
None
How was the solution implemented (if it's not obvious)?
added a static ctor for DropShadowDirectionEffect:
Checklist
Breaking changes
Obsoletions / Deprecations
Fixed issues