Fix TimePicker breaking change, when using pre-11.2 styles #17516
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxkatz6
added
bug
backport-candidate-11.2.x
maxkatz6
removed
the
backport-candidate-11.2.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
In 11.2 TimePicker got a new feature with seconds picker option.
Unfortunately, TimePicker templates are very limiting, and any such change breaks templates from third party themes, which weren't updated at the exact time (so, all of them).
This PR adds a check, whether template is up-to date or not, before trying to access second template parts.
For the better fix see #17515
What is the current behavior?
NullReferenceException, if pre-11.2 template is used with 11.2 control.
What is the updated/expected behavior with this PR?
Seconds are ignored, if pre-11.2 template is used with 11.2 control.
Tested by applying 11.1 control theme to the control.