-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
AutoCompleteBox don't lose text selection when contextmenu opens #17462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AutoCompleteBox don't lose text selection when contextmenu opens #17462
Conversation
3c77bb9
to
b236062
Compare
You can test this PR using the following package version. |
|
@cla-avalonia agree |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution! The matching unit test is really appreciated. A small change is needed though.
b236062
to
0e53305
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
You can test this PR using the following package version. |
What does the pull request do?
When implementing copy and paste context menu items for AutoCompleteBox it's not possible because text selection gets lost.
This issue was solved also for TextBox in #4498
What is the current behavior?
Selection is gone.
What is the updated/expected behavior with this PR?
Selection should be the same.
How was the solution implemented (if it's not obvious)?
Checklist
Breaking changes
Obsoletions / Deprecations
Fixed issues
Fixes #17453