Use the himetric location instead of the pixel location. #16850
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxkatz6
reviewed
Aug 29, 2024
|
You can test this PR using the following package version. |
maxkatz6
approved these changes
Oct 9, 2024
|
@walterlv There are some conflicts that must be resolved (edit: and your branch is write-protected). |
walterlv
force-pushed
the
t/walterlv/himetric-location
branch
from
a2dee88 to
295f0c8
Compare
|
@MrJul Confliction Resolved 😉 |
|
You can test this PR using the following package version. |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
walterlv
added a commit
to dotnet-campus/Avalonia
that referenced
this pull request
Nov 27, 2024
…16850) * Add an overload with more precise point transformation. * Use the himetric location instead of the pixel location. * The pen also use the himetric location. * Similar codes. * Use the raw location instead of the predicted one. See: https://learn.microsoft.com/en-us/windows/win32/api/winuser/ns-winuser-pointer_info * Fix wrong multi-screen location * Add lost win32 api. (cherry picked from commit 0bd90d8)
walterlv
added a commit
to dotnet-campus/Avalonia
that referenced
this pull request
Feb 6, 2025
…16850) * Add an overload with more precise point transformation. * Use the himetric location instead of the pixel location. * The pen also use the himetric location. * Similar codes. * Use the raw location instead of the predicted one. See: https://learn.microsoft.com/en-us/windows/win32/api/winuser/ns-winuser-pointer_info * Fix wrong multi-screen location * Add lost win32 api. (cherry picked from commit 0bd90d8)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
This PR uses the
ptHimetricLocationin thePOINTER_INFOstruct instead of theptPixelLocationwhich makes the touch pointer more accurate.As a result, if we draw all the touch points line-by-line, the path will be more smooth and accurate. See the following image for the comparison:
The following is a sample output of the touch points with the
ptPixelLocationandptHimetricLocation:What is the current behavior?
ptPixelLocationwhich is an integer value.PointToClientmethod only receivesPixelPointparameter which loses the decimal part of the touch point.What is the updated/expected behavior with this PR?
ptHimetricLocationwhich is a float value.PointToClientmethod receivesPointparameter which keeps the decimal part of the touch point. I've written a new overload for the existed one.How was the solution implemented (if it's not obvious)?
Checklist
Breaking changes
I think there is no breaking changes.
Obsoletions / Deprecations
Fixed issues