Prevent .NET from randomly calling WndProc in RequestCompositionBatchCommitAsync #16804
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…CommitAsync This method isn't reentrancy-friendly
|
You can test this PR using the following package version. |
kekekeks
added
bug
backport-candidate-11.0.x
maxkatz6
approved these changes
Aug 26, 2024
grokys
pushed a commit
that referenced
this pull request
Sep 9, 2024
…CommitAsync (#16804) This method isn't reentrancy-friendly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This method isn't reentrancy-friendly and that less-than-stellar way of dealing with COM objects in .NET is causing this to happen
This happens only on windows and only due to .NET locks being defective on STA threads, which is why it was hard to catch.
Should fix #15226
Thanks arnirichard for the stack trace which made it obvious