Skip to content

X11 - Refactor x11 Screen API #16705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 20, 2024
Merged

X11 - Refactor x11 Screen API #16705

merged 1 commit into from
Aug 20, 2024

Conversation

emmauss
Copy link
Contributor

@emmauss emmauss commented Aug 15, 2024

What does the pull request do?

Refactors x11 Screen api completing #16572 .

Fixed issues

Fixes #16572

@emmauss emmauss requested a review from maxkatz6 August 15, 2024 15:09
@avaloniaui-bot
Copy link

You can test this PR using the following package version. 11.2.999-cibuild0051281-alpha. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@maxkatz6 maxkatz6 requested a review from kekekeks August 15, 2024 21:14
Copy link
Member

@maxkatz6 maxkatz6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New API is implemented as expected.

@avaloniaui-bot
Copy link

You can test this PR using the following package version. 11.2.999-cibuild0051349-alpha. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

Copy link
Member

@jmacato jmacato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

seems to work, lgtm thanks @emmauss

@jmacato jmacato added this pull request to the merge queue Aug 20, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 20, 2024
@maxkatz6 maxkatz6 merged commit 49c7d25 into master Aug 20, 2024
12 checks passed
@maxkatz6 maxkatz6 deleted the x11_screen branch August 20, 2024 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extended Screens support on mobile/linux platforms
4 participants