-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
feat(Geometries): PolyBezierSegment #16664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Geometries): PolyBezierSegment #16664
Conversation
You can test this PR using the following package version. |
points[i + 2], | ||
isStroken); | ||
} | ||
var delta = i - points.Count; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think WPF doesn't trigger a warning in this case and simply silently skips the points
https://github.com/dotnet/wpf/blob/e7ddcf41e1342d889aa7273b836909bdf15154e2/src/Microsoft.DotNet.Wpf/src/PresentationCore/System/Windows/Media/ByteStreamGeometryContext.cs#L651-L657
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I saw that. I thought it would be helpful for developers to have feedback if they were using incorrect values so they could more easily look for bugs.
Do I remove the warning?
You can test this PR using the following package version. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am fine with keeping the warning.
LGTM otherwise.
What does the pull request do?
What is the current behavior?
What is the updated/expected behavior with this PR?
How was the solution implemented (if it's not obvious)?
Checklist
Breaking changes
Obsoletions / Deprecations
Fixed issues
Closes #12741