Skip to content

feat(Geometries): PolyBezierSegment #16664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

workgroupengineering
Copy link
Contributor

@workgroupengineering workgroupengineering commented Aug 12, 2024

What does the pull request do?

What is the current behavior?

What is the updated/expected behavior with this PR?

How was the solution implemented (if it's not obvious)?

Checklist

Breaking changes

Obsoletions / Deprecations

Fixed issues

Closes #12741

@avaloniaui-bot
Copy link

You can test this PR using the following package version. 11.2.999-cibuild0051175-alpha. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

points[i + 2],
isStroken);
}
var delta = i - points.Count;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw that. I thought it would be helpful for developers to have feedback if they were using incorrect values ​​so they could more easily look for bugs.

Do I remove the warning?

@workgroupengineering workgroupengineering marked this pull request as ready for review August 12, 2024 15:37
@avaloniaui-bot
Copy link

You can test this PR using the following package version. 11.2.999-cibuild0051182-alpha. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

Copy link
Member

@maxkatz6 maxkatz6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am fine with keeping the warning.
LGTM otherwise.

@maxkatz6 maxkatz6 added this pull request to the merge queue Aug 15, 2024
Merged via the queue into AvaloniaUI:master with commit 6e35fd2 Aug 15, 2024
11 checks passed
@workgroupengineering workgroupengineering deleted the feature/PolyBezierSegment branch August 15, 2024 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing PolyBezierSegment
4 participants