Skip to content

TrayIcon tests are flacky, disable them #16265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 10, 2024
Merged

TrayIcon tests are flacky, disable them #16265

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
06bd899
TrayIcon tests are flacky, disable them
maxkatz6 Jul 9, 2024
52dc2a7
Skip Horizontal_Changes_Value_Dragging_Thumb_Left too
maxkatz6 Jul 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tests/Avalonia.IntegrationTests.Appium/SliderTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ public SliderTests(DefaultAppFixture fixture)
reset.Click();
}

[Fact]
[Fact(Skip = "Flaky test, slider value is sometimes off by 1 or 2 steps.")]
public void Horizontal_Changes_Value_Dragging_Thumb_Right()
{
var slider = _session.FindElementByAccessibilityId("HorizontalSlider");
Expand All @@ -44,7 +44,7 @@ public void Horizontal_Changes_Value_Dragging_Thumb_Right()
Assert.True(currentThumbRect.Left > initialThumbRect.Left);
}

[Fact]
[Fact(Skip = "Flaky test, slider value is sometimes off by 1 or 2 steps.")]
public void Horizontal_Changes_Value_Dragging_Thumb_Left()
{
var slider = _session.FindElementByAccessibilityId("HorizontalSlider");
Expand Down
6 changes: 3 additions & 3 deletions tests/Avalonia.IntegrationTests.Appium/TrayIconTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ public TrayIconTests(DefaultAppFixture fixture)
}

// Left click is only supported on Windows.
[PlatformFact(TestPlatforms.Windows)]
[PlatformFact(TestPlatforms.Windows, Skip = "Flaky test")]
public void Should_Handle_Left_Click()
{
var avaloinaTrayIconButton = GetTrayIconButton(_rootSession ?? _session, TrayIconName);
Expand All @@ -46,7 +46,7 @@ public void Should_Handle_Left_Click()
Assert.True(checkBox.GetIsChecked());
}

[Fact]
[Fact(Skip = "Flaky test")]
public void Should_Handle_Context_Menu_Item_Click()
{
var avaloinaTrayIconButton = GetTrayIconButton(_rootSession ?? _session, TrayIconName);
Expand All @@ -64,7 +64,7 @@ public void Should_Handle_Context_Menu_Item_Click()
Assert.True(checkBox.GetIsChecked());
}

[Fact]
[Fact(Skip = "Flaky test")]
public void Can_Toggle_TrayIcon_Visibility()
{
var avaloinaTrayIconButton = GetTrayIconButton(_rootSession ?? _session, TrayIconName);
Expand Down
Loading