-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Refactor WASM input and dom-callbacks to work with multithreading #15849
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
ee67f86
Make resizing work again
maxkatz6 288108d
Fix various DOM events on multithreading
maxkatz6 19a7b22
Refactor WASM input to work with multithreading
maxkatz6 a9db115
Minor improvements for drag n drop
maxkatz6 b615fc4
Use Microsoft.NET.Sdk.WebAssembly in control catalog browser
maxkatz6 19b6f1c
Shortcut resolved exports
maxkatz6 36fd3fa
Fix DomHelper.GetCurrentDocumentVisibility not working
maxkatz6 b044006
Fix embed sample
maxkatz6 c8c983f
Remove ManualTriggerRenderTimer
maxkatz6 eedb0fb
Use pre-saved globalThis instance to make sure that JSImport interop …
maxkatz6 e9e2859
Implement managed dispatcher for browser with event grouping
maxkatz6 b8ab986
Fix InputHelper.GetCoalescedEvents usage
maxkatz6 4a6e4dc
Nits after review
maxkatz6 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
32 changes: 8 additions & 24 deletions
32
src/Browser/Avalonia.Browser/BrowserActivatableLifetime.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,36 +1,20 @@ | ||
using System; | ||
using Avalonia.Browser.Interop; | ||
using Avalonia.Controls.ApplicationLifetimes; | ||
using Avalonia.Threading; | ||
|
||
namespace Avalonia.Browser; | ||
|
||
internal class BrowserActivatableLifetime : IActivatableLifetime | ||
internal class BrowserActivatableLifetime : ActivatableLifetimeBase | ||
{ | ||
public BrowserActivatableLifetime() | ||
public void OnVisibilityStateChanged(string visibilityState) | ||
{ | ||
bool? initiallyVisible = InputHelper.SubscribeVisibilityChange(visible => | ||
var visible = visibilityState == "visible"; | ||
if (visible) | ||
{ | ||
initiallyVisible = null; | ||
(visible ? Activated : Deactivated)?.Invoke(this, new ActivatedEventArgs(ActivationKind.Background)); | ||
}); | ||
|
||
// Trigger Activated as an initial state, if web page is visible, and wasn't hidden during initialization. | ||
if (initiallyVisible == true) | ||
OnActivated(ActivationKind.Background); | ||
} | ||
else | ||
{ | ||
_ = Dispatcher.UIThread.InvokeAsync(() => | ||
{ | ||
if (initiallyVisible == true) | ||
{ | ||
Activated?.Invoke(this, new ActivatedEventArgs(ActivationKind.Background)); | ||
} | ||
}, DispatcherPriority.Background); | ||
OnDeactivated(ActivationKind.Background); | ||
} | ||
} | ||
|
||
public event EventHandler<ActivatedEventArgs>? Activated; | ||
public event EventHandler<ActivatedEventArgs>? Deactivated; | ||
|
||
public bool TryLeaveBackground() => false; | ||
public bool TryEnterBackground() => false; | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suspect that
AvaloniaLocator.Current.GetService<BrowserPlatformOptions>()?.PreferManagedThreadDispatcher != false;
check will always succeed regardless of theoptions
parameter passed to StartBrowserAppAsync. Only one registered with.With
will be usedThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We already have
AvaloniaLocator.CurrentMutable.Bind<BrowserPlatformOptions>().ToConstant(options);
for that case. It's auto-registered.