Skip to content

Implement missing browser stream methods #15701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 13, 2024

Conversation

maxkatz6
Copy link
Member

What does the pull request do?

  1. Implements missing methods on browser read/write file streams.
  2. Optimizes write method to avoid extra buffer copy.

Fixed issues

Fixes #15429

@maxkatz6 maxkatz6 added bug os-browser backport-candidate-11.1.x Consider this PR for backporting to 11.1 branch labels May 13, 2024
@maxkatz6 maxkatz6 merged commit 3dc92e0 into master May 13, 2024
@maxkatz6 maxkatz6 deleted the implement-missing-browser-stream-methods branch May 13, 2024 07:37
grokys pushed a commit that referenced this pull request Jun 4, 2024
* Implement missing WriteAsync/BeginWrite/BeginRead browser stream methods

* Optimize/hack StreamHelper.write to use buffer directly
@grokys grokys added backported-11.1.x and removed backport-candidate-11.1.x Consider this PR for backporting to 11.1 branch labels Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stream obtained from IStorageFile.OpenWriteAsync on browser throws exception on being passed to CopyToAsync
2 participants