Skip to content

[TextBox] fix double click on TextBox cannot select word on touch device #15606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ijklam
Copy link
Contributor

@ijklam ijklam commented May 4, 2024

What does the pull request do?

exclude double click from check conditions of OnPointerMoved

What is the current behavior?

double click on TextBox cannot select word on touch device

Screenrecorder-2024-05-05-00-12-23-306.mp4

What is the updated/expected behavior with this PR?

double click on TextBox can select word on touch device

How was the solution implemented (if it's not obvious)?

Checklist

Breaking changes

Obsoletions / Deprecations

Fixed issues

@avaloniaui-bot
Copy link

You can test this PR using the following package version. 11.2.999-cibuild0048076-alpha. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@xLEGiON
Copy link
Contributor

xLEGiON commented May 5, 2024

This breaks the word selection. You can no longer double click, hold, and drag to update the selection by word.

@ijklam
Copy link
Contributor Author

ijklam commented May 5, 2024

This breaks the word selection. You can no longer double click, hold, and drag to update the selection by word.

Fixed

@avaloniaui-bot
Copy link

You can test this PR using the following package version. 11.2.999-cibuild0048100-alpha. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@maxkatz6 maxkatz6 added the backport-candidate-11.1.x Consider this PR for backporting to 11.1 branch label May 6, 2024
@maxkatz6 maxkatz6 merged commit fd78546 into AvaloniaUI:master May 6, 2024
maxkatz6 pushed a commit that referenced this pull request May 8, 2024
…ice (#15606)

* fix double click on TextBox cannot select word on touch device

* fix

* fix: double click and drag to change selection
@maxkatz6 maxkatz6 added backported-11.1.x and removed backport-candidate-11.1.x Consider this PR for backporting to 11.1 branch labels May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants