Add ItemsControl.PreparingContainer event
#14153
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can test this PR using the following package version. |
|
Actually, while this change does fix the issue we were having, an even better solution for us would be to hook into template construction (to record the DI context) and template instantiation (to restore the DI context). We can do this by creating our own template types derived from the normal ones. Then we can get the behaviour we need at any time, without an I'll leave this PR open, as IMO it still makes sense to add the event for general purpose use. |
MrJul
approved these changes
Oct 10, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new event that is raised before an item container is prepared for use.
What is the current behavior?
Currently it is not possible to intercept item container preparation. There is only the
ContainerPreparedevent, which is raised after the fact.This causes issues in our product, which sometimes needs to do DI work before constructing item container templates.
Breaking changes
None
Obsoletions / Deprecations
None