Add "EGL_ANGLE_flexible_surface_compatibility" ext check #13080
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxkatz6
added
the
backport-candidate-11.0.x
|
You can test this PR using the following package version. |
maxkatz6
force-pushed
the
check-if-extension-exists
branch
from
f89f070 to
0f4e467
Compare
maxkatz6
changed the title
kekekeks
reviewed
Sep 30, 2023
kekekeks
reviewed
Sep 30, 2023
kekekeks
approved these changes
Sep 30, 2023
|
You can test this PR using the following package version. |
grokys
pushed a commit
that referenced
this pull request
Oct 2, 2023
* Add "EGL_ANGLE_flexible_surface_compatibility" ext check * Use stackalloc with CreatePBufferFromClientBuffer attributes * Fix broken API
grokys
added
backported-11.0.x
and removed
backport-candidate-11.0.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
Extension check that fixes Avalonia compatibility with newer Angle versions.
"EGL_ANGLE_flexible_surface_compatibility" extension was removed somewhere after 2020 angle releases, while Avalonia still used it.
How was the solution implemented (if it's not obvious)?
We could remove this attribute and upgrade Angle to the newest, but to keep compatibility with older native binaries, an extension check was added.
Also, as this code is reused between normal Angle and DXGI, some code was reused.
Fixes
Probably fixes #10405 (comment) specific comment. And also possibly fixes Angle on ARM64, when used with newer builds (Edge builds for example).