Fix ItemsControl logical child removal #13019
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And one passing test to confirm that it works when virtualization is enabled. Co-Authored-By: Jan Kristian Bjerke <[email protected]>
Fixes test in previous commit. Co-Authored-By: Jan Kristian Bjerke <[email protected]>
maxkatz6
approved these changes
Sep 25, 2023
|
You can test this PR using the following package version. |
grokys
added
the
backport-candidate-11.0.x
grokys
pushed a commit
that referenced
this pull request
Oct 2, 2023
…child-removal Fix ItemsControl logical child removal
grokys
added
backported-11.0.x
and removed
backport-candidate-11.0.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
In a non-virtualizing
itemsControl, control items were not being removed from theLogicalChildrencollection: only items that are not their own container were being removed. This was incorrect.Add a unit test and fix this. Thanks to @jankrib for reporting this with a unit test and fix.