Skip to content

Fix DataGridHeader style #12544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 16, 2023
Merged

Fix DataGridHeader style #12544

merged 2 commits into from
Aug 16, 2023

Conversation

Flithor
Copy link
Contributor

@Flithor Flithor commented Aug 15, 2023

What does the pull request do?

Update DataGrid Fluent style.

What is the current behavior?

DataGridHeader right separater line will cover by header background.

What is the updated/expected behavior with this PR?

Update DataGrid Fluent style make DataGridHeader separater won't be covered.

How was the solution implemented (if it's not obvious)?

Use Panel control boxing the Grid control clip it.

Checklist

Breaking changes

Nope

Obsoletions / Deprecations

Nope

Fixed issues

Fixes #11938

@Flithor
Copy link
Contributor Author

Flithor commented Aug 15, 2023

@dotnet-policy-service agree

@avaloniaui-team
Copy link
Contributor

You can test this PR using the following package version. 11.0.999-cibuild0038430-beta. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

Copy link
Member

@maxkatz6 maxkatz6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@maxkatz6 maxkatz6 added this pull request to the merge queue Aug 15, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 16, 2023
@maxkatz6 maxkatz6 added this pull request to the merge queue Aug 16, 2023
Merged via the queue into AvaloniaUI:master with commit a0a8e94 Aug 16, 2023
@maxkatz6 maxkatz6 added the backport-candidate-11.0.x Consider this PR for backporting to 11.0 branch label Dec 28, 2023
@maxkatz6 maxkatz6 added backported-11.0.x and removed backport-candidate-11.0.x Consider this PR for backporting to 11.0 branch labels Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Separator of DataGridColumnHeader will clipped by header bound.
3 participants