Fix AutoCompleteBox not opening when the text box is empty #12057
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dotnet-policy-service agree |
|
You can test this PR using the following package version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
This PR removes an old workaround that mistakenly prevented the
AutoCompleteBoxdropdown from opening in certain scenarios. More context is provided here.What is the current behavior?
Previously, an
AutoCompleteBoxwithMinimumPrefixLength=0would not open when the user pressed the down arrow key with no text in the text box.What is the updated/expected behavior with this PR?
When pressing the down arrow key in an
AutoCompleteBoxwithMinimumPrefixLength=0, the dropdown will now open as expected.How was the solution implemented (if it's not obvious)?
I removed a check that was introduced as a workaround in #1570 in order to fix #1554. The underlying cause for #1554 appears to have been resolved since then, so the workaround is no longer needed.
Checklist
Fixed issues
Fixes #8903