Skip to content

EllipseGeometry Clone Fix #11773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 14, 2023
Merged

EllipseGeometry Clone Fix #11773

merged 3 commits into from
Jun 14, 2023

Conversation

robloo
Copy link
Contributor

@robloo robloo commented Jun 14, 2023

What does the pull request do?

  1. Fixes EllipseGeometry.Clone() method to account for all properties and rendering modes
  2. Fixes some duplicate period occurrences that were noticed

How was the solution implemented (if it's not obvious)?

Obvious

Checklist

Breaking changes

None

Obsoletions / Deprecations

None

Fixed issues

Fixes #11754

@avaloniaui-team
Copy link
Contributor

You can test this PR using the following package version. 11.0.999-cibuild0036489-beta. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@maxkatz6 maxkatz6 enabled auto-merge June 14, 2023 02:11
@maxkatz6 maxkatz6 added this pull request to the merge queue Jun 14, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 14, 2023
@maxkatz6 maxkatz6 added this pull request to the merge queue Jun 14, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 14, 2023
@jmacato jmacato added this pull request to the merge queue Jun 14, 2023
Merged via the queue into AvaloniaUI:master with commit d78dc2a Jun 14, 2023
@robloo robloo deleted the ellipse-geometry branch June 14, 2023 09:45
danwalmsley pushed a commit that referenced this pull request Aug 10, 2023
EllipseGeometry Clone Fix

# Conflicts:
#	src/Avalonia.Base/AvaloniaObjectExtensions.cs
#	src/Avalonia.Base/Media/TextFormatting/Unicode/BiDiAlgorithm.cs
danwalmsley pushed a commit that referenced this pull request Aug 10, 2023
EllipseGeometry Clone Fix

# Conflicts:
#	src/Avalonia.Base/AvaloniaObjectExtensions.cs
#	src/Avalonia.Base/Media/TextFormatting/Unicode/BiDiAlgorithm.cs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EllipseGeometry.Clone missing Center, RadiusX, and RadiusY property assignments
4 participants