MenuItems from ContextMenu.ItemTemplate disabled / greyed out when Command parameter is used

[LazaroOnline]

Describe the bug

When a MenuItem Command is binded while in a ContextMenu.ItemTemplate, it seems to be disabled (gray out) and clicking does not work.
Note that all other values bind correctly from the same model, just not the command, and that the command binding is also compiled correctly.

The issue only occurs when ItemsSource with ItemTemplate is used, but if using static MenuItems it does work, example:

<ContextMenu x:DataType="model:User" ItemsSource="{Binding UserLinks}">
  <ContextMenu.ItemTemplate>
	<MenuItem Header="Test" Command="{Binding SomeFUnctionFromUserClass}/>
  </ContextMenu.Item
</ContextMenu>

But of course, static items cannot replace dynamic templates, so it is not a workaround.

To Reproduce

Checkout this simple example in this repo (in the branch issue-example-contextmenu-greyedout):

https://github.com/LazaroOnline/AvaloniaDataGridRowFlyoutRefresh-BugSample/tree/issue-example-contextmenu-greyedout

Run the app and try to right click on the DataGrid row to see the MenuItems that should not be disabled, but they are.

Here is a preview of the axaml from the repo:

<DataGrid.Styles>
  <Style Selector="DataGridRow">
	<Setter Property="ContextMenu">
	  <ContextMenu x:DataType="model:User" ItemsSource="{Binding UserLinks}">
		<ContextMenu.ItemTemplate>
		  <DataTemplate DataType="model:Link">
			<MenuItem Header="{Binding LinkName}" Command="{Binding OpenUrl}" />
		  </DataTemplate>
		</ContextMenu.ItemTemplate>
	  </ContextMenu>
	</Setter>
  </Style>
</DataGrid.Styles>

Expected behavior

No response

Avalonia version

11.2.3

OS

Windows

Additional context

No response

[LazaroOnline]

Ok, I found the solution using... Styles.
this is confusing and hard to discover, lead me to a lot of frustration and thus many users are reporting these kind of things.

Here is the work-around:

<DataGrid.Styles>
  <Style Selector="DataGridRow">
    <Setter Property="ContextMenu">
      <ContextMenu x:DataType="model:User" ItemsSource="{Binding UserLinks}">
        <ContextMenu.Styles>
          <Style Selector="MenuItem" x:DataType="model:Link">
            <Setter Property="Header" Value="{Binding LinkName}"/>
            <Setter Property="Command" Value="{Binding OpenUrl}"/>
          </Style>
        </ContextMenu.Styles>
      </ContextMenu>
    </Setter>
  </Style>
</DataGrid.Styles>

I would say that using styles is a workaround but not a solution, the control should have a way to pass the ItemSource and MenuItems in a sane way a developer can use without going crazy...
Something like this should be possible:

<DataGrid ItemsSource="{Binding UserList}">
  <DataGrid.ContextMenu x:DataType="model:User" ItemsSource="{Binding UserLinks}">
    <MenuItem Header="LinkName" Binding="{Binding OpenUrl}" />
  </DataGrid.ContextMenu>
  ...
</DataGrid>

Data related properties like the Text/Content of a button and the Command should not be considered styles.

[vpenades]

Found the same issue, it's still broken using Avalonia 11.3.0

[maxkatz6]

As it is now, ItemTemplate defines content for the item container, not the container itself. In your case, it will create a new MenuItem for each MenuItem container, nesting them and generating unexpected output.
With 11.3.0 we have a compiler warning to prevent such mistakes - #18132

Solution with styles is a correct alternative. Another one would be to use ItemContainerTheme.

[vpenades]

I've found this issue and I have an extra ball.

If DataTemplate is not the right approach and the recomendation is to use styles, then, how it is possible to handle multiple Data Types?

as in:

<Window.DataTemplates>

<DataTemplate x:DataType="mvvm:Type1">      

    <MenuItem Header="{Binding Header}" >      
      <MenuItem.Styles> 
        <Style Selector="MenuItem">
          <Setter Property="Command" Value="{Binding Command}" />
        </Style>  
      </MenuItem.Styles>      
    </MenuItem>      

  </DataTemplate>

  <DataTemplate x:DataType="mvvm:Type2">      

    <MenuItem Header="{Binding Header}" >
      <Interaction.Behaviors>
        <MenuItemOpenFolderPickerBehavior AllowMultiple="False" Command="{Binding Command}" />
      </Interaction.Behaviors>
    </MenuItem>

  </DataTemplate>  
  
</Window.DataTemplates>

Notice that the DataTemplate of Type2 uses an Interaction Behavior, I have no clue how to set this up using styles.

I would say that although styles might be the correct solution from the programatic point of view, it is the wrong solution from design point of view.