InjectAvaloniaXamlOutput appears to mangle property IntermediateAssembly on multiple runs and prevents trimming

[noorez]

Describe the bug

(For some reason this only appears on android builds..)

It looks like when InjectAvaloniaXamlOutput build target is run multiple times (for this case: (target "InjectAvaloniaXamlOutput" depends on it):) which has already run because "Compile" target required it, the path becomes mangled.

CompileAvaloniaXamlInputs=
 816620                            obj/Release/net8.0-android/Avalonia/project.dll
 816621                                    AvaloniaCompileOutput=obj/Release/net8.0-android/Avalonia/Avalonia/project.dll

notice how there are now two /Avalonia/Avalonia nested directories when in fact all the build objects are only in Avalonia.

This in turn causes the trimmer targets to not look in the correct location for the assemblies which need to be trimmed

To Reproduce

Compile android targets when trimming enabled.

Expected behavior

previous version on which this worked without issue for me 11.1.999-cibuild0045786-beta. expect that it should also work in recent versions too.

Avalonia version

11.1.2

OS

Android

Additional context

No response

[timunie]

Can you try latest nightly in a minimum sample? If it still is a bug for you, share the minimum sample please.

[TomEdwardsEnscape]

The issue will be that PrepareToCompileAvaloniaXaml is running multiple times. But a target is not supposed to run twice.

In addition to a code sample, please compile with binary logging enabled and attach the .binlog output. Sample command: dotnet build -bl:MyLog.binlog.

[noorez]

https://github.com/noorez/AvaloniaTest17099 Test code which reproduces the issue

[noorez]

MyLog.log
attached the binlog requested.

Note, this didn't appear to produce any errors on output, however, Visual Studio and also msbuild from the console do produce the error

[noorez]

I think what might be throwing off the msbuild target is the <ApplicationIcon> directive in the android project you can see in the test project I uploaded...

edit: didn't format above correctly to show it seemed to be the addition of ApplicationIcon to the android project which exposed the issue...

[TomEdwardsEnscape]

This is the problem: it's running inner builds, and overriding the path to the intermediate assembly with its own value:

The good news is that it also configures the SkipCompilerExecution property. We should be respecting this anyway, but aren't. By skipping the Avalonia XAML targets when that property is true we should be able to fix the issue.

[TomEdwardsEnscape]

Please try with the build from the linked PR (once it has been generated).

[noorez]

pushed update to my test project to show that it works now (it also builds correctly on the actual project)

[noorez]

while the issue with building was fixed and it produced the various android binaries, the app crashed, and this was taken from adb. It appears that perhaps the patch skipped too much when trying to avoid the additional transformation of the msbuild properties?

9-27 10:09:17.197 14531 14531 E AndroidRuntime: Process: air.com.myapp, PID: 14531
09-27 10:09:17.197 14531 14531 E AndroidRuntime: android.runtime.JavaProxyThrowable: [Avalonia.Markup.Xaml.XamlLoadException]: No precompiled XAML found for myapp.Client.App, make sure to specify x:Class and include your XAML file as AvaloniaResource
09-27 10:09:17.197 14531 14531 E AndroidRuntime: 	at Avalonia.Markup.Xaml.AvaloniaXamlLoader.Load(Unknown Source:0)
09-27 10:09:17.197 14531 14531 E AndroidRuntime: 	at myapp.Client.App.Initialize(Unknown Source:0)
09-27 10:09:17.197 14531 14531 E AndroidRuntime: 	at Avalonia.AppBuilder.SetupUnsafe(Unknown Source:0)
09-27 10:09:17.197 14531 14531 E AndroidRuntime: 	at Avalonia.AppBuilder.Setup(Unknown Source:0)
09-27 10:09:17.197 14531 14531 E AndroidRuntime: 	at Avalonia.AppBuilder.SetupWithLifetime(Unknown Source:0)
09-27 10:09:17.197 14531 14531 E AndroidRuntime: 	at Avalonia.Android.AvaloniaMainActivity.InitializeAvaloniaView(Unknown Source:0)
09-27 10:09:17.197 14531 14531 E AndroidRuntime: 	at Avalonia.Android.AvaloniaActivity.OnCreate(Unknown Source:0)
09-27 10:09:17.197 14531 14531 E AndroidRuntime: 	at PasswordServer.Client.Android.MainActivity.OnCreate(Unknown Source:0)
09-27 10:09:17.197 14531 14531 E AndroidRuntime: 	at Android.App.Activity.n_OnCreate_Landroid_os_Bundle_(Unknown Source:0)
09-27 10:09:17.197 14531 14531 E AndroidRuntime: 	at Android.Runtime.JNINativeWrapper.Wrap_JniMarshal_PPL_V(Unknown Source:0)
09-27 10:09:17.197 14531 14531 E AndroidRuntime: 	at crc64ef7a11524a16ed7d.MainActivity.n_onCreate(Native Method)
09-27 10:09:17.197 14531 14531 E AndroidRuntime: 	at crc64ef7a11524a16ed7d.MainActivity.onCreate(MainActivity.java:41)
09-27 10:09:17.197 14531 14531 E AndroidRuntime: 	at android.app.Activity.performCreate(Activity.java:8975)
09-27 10:09:17.197 14531 14531 E AndroidRuntime: 	at android.app.Activity.performCreate(Activity.java:8944)
09-27 10:09:17.197 14531 14531 E AndroidRuntime: 	at android.app.Instrumentation.callActivityOnCreate(Instrumentation.java:1456)
09-27 10:09:17.197 14531 14531 E AndroidRuntime: 	at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:4146)
09-27 10:09:17.197 14531 14531 E AndroidRuntime: 	at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:4322)
09-27 10:09:17.197 14531 14531 E AndroidRuntime: 	at android.app.servertransaction.LaunchActivityItem.execute(LaunchActivityItem.java:103)
09-27 10:09:17.197 14531 14531 E AndroidRuntime: 	at android.app.servertransaction.TransactionExecutor.executeCallbacks(TransactionExecutor.java:139)
09-27 10:09:17.197 14531 14531 E AndroidRuntime: 	at android.app.servertransaction.TransactionExecutor.execute(TransactionExecutor.java:96)
09-27 10:09:17.197 14531 14531 E AndroidRuntime: 	at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2685)
09-27 10:09:17.197 14531 14531 E AndroidRuntime: 	at android.os.Handler.dispatchMessage(Handler.java:106)
09-27 10:09:17.197 14531 14531 E AndroidRuntime: 	at android.os.Looper.loopOnce(Looper.java:230)
09-27 10:09:17.197 14531 14531 E AndroidRuntime: 	at android.os.Looper.loop(Looper.java:319)
09-27 10:09:17.197 14531 14531 E AndroidRuntime: 	at android.app.ActivityThread.main(ActivityThread.java:8918)
09-27 10:09:17.197 14531 14531 E AndroidRuntime: 	at java.lang.reflect.Method.invoke(Native Method)
09-27 10:09:17.197 14531 14531 E AndroidRuntime: 	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:608)
09-27 10:09:17.197 14531 14531 E AndroidRuntime: 	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1103)

[TomEdwardsEnscape]

Please send another .binlog.

[noorez]

Attached is the new binlog (test repo updated as well).

dotnet publish .\AvaloniaApplication2.Android\AvaloniaApplication2.Android.csproj -c Release -p:ApplicationVersion=3003007 -p:ApplicationDisplayVersion=3.3.7 -o .\Packages\Android -bl:MyLog.binlog

MyLog.log