Allow Columns to be modified / re-ordered for HierarchicalDataSources #310
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… are re-ordered. this was preventing users from changing the column order at runtime.
grokys
approved these changes
Oct 10, 2024
|
Maybe it should check whether an expander column has been added or removed and throw in that case? |
will handle these cases |
danwalmsley
force-pushed
the
fixes/allow-reordering-tree-columns
branch
from
ce29de0 to
0565c43
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HierarchicalTreeDataGridSource handles OnColumnsCollectionChanged to grab a reference to the expander columns.
However it throws NotImplementException for all actions other than Add, this prevents the user from re-ordering the columns at runtime.
It currently works for Flat sources, but this minor bug prevents it from working for Hierarchical sources.
How the fix works:
simply no need to throw NotImplementedException here.