Ignore control characters on text input #296
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When hitting the
Escape
key or other control keys, the_selection?.OnTextInput()
method is executed, passing the string "\u001B" (ASCII 27 control char) to theHandleTextInput
method.This method matches every row because this comparison always returns true (see this .NET fiddle), causing that the selection is moved 1 row down every time the user hits the
Escape
key:This PR changes filters out control characters on method
OnTextInput
.@grokys Question: Should Avalonia filter out these events in
OnTextInput
when the text contains control characters?