Inserting items makes the StartU unstable. #229
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes layout problems in a kinda complex scenario where items are inserted before doing a `BringIntoView`. Couldn't manage to write a test, but all other updates of `_firstIndex` make `_startUUnstable`: this was one missing that was an oversight.
grokys
added a commit
to AvaloniaUI/Avalonia
that referenced
this pull request
Nov 28, 2023
This ports the fix in AvaloniaUI/Avalonia.Controls.TreeDataGrid#229 to Avalonia. Fixes #12744
github-merge-queue bot
pushed a commit
to AvaloniaUI/Avalonia
that referenced
this pull request
Nov 28, 2023
* Added failing test for #12744. * Inserting items makes the StartU unstable. This ports the fix in AvaloniaUI/Avalonia.Controls.TreeDataGrid#229 to Avalonia. Fixes #12744
maxkatz6
pushed a commit
to AvaloniaUI/Avalonia
that referenced
this pull request
Dec 5, 2023
* Added failing test for #12744. * Inserting items makes the StartU unstable. This ports the fix in AvaloniaUI/Avalonia.Controls.TreeDataGrid#229 to Avalonia. Fixes #12744 #Conflicts: # tests/Avalonia.Controls.UnitTests/VirtualizingStackPanelTests.cs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes layout problems in a kinda complex scenario where items are inserted before doing a
BringIntoView. Couldn't manage to write a test, but all other updates of_firstIndexmake_startUUnstable: this was one missing that was an oversight.