Fix nodes appearing in wrong position #213
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Doesn't catch the issue I'm looking for but might be useful?
Previously, a cell with focus wasn't being recycled when the parent row was removed as `TreeDataGridPresenterBase.RecycleElement` was being called on it, which has logic to keep the focused element around. This makes no sense when the containing row has been removed, instead `RecycleElementOnItemRemoved` should be called. Add `TreeDataGridPresenterBase.UnrealizeOnRowRemoved` (with an override in `TreeDataGridRowsPresenter`) and make `TreeDataGridPresenterBase.RecycleElementOnItemRemoved` call it.
As it will be cleared when the element is realized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, a cell with focus wasn't being recycled when the parent row was removed as
TreeDataGridPresenterBase.RecycleElementwas being called on it, which has logic to keep the focused element around. This makes no sense when the containing row has been removed, insteadRecycleElementOnItemRemovedshould be called.Add
TreeDataGridPresenterBase.UnrealizeOnRowRemoved(with an override inTreeDataGridRowsPresenter) and makeTreeDataGridPresenterBase.RecycleElementOnItemRemovedcall it.Fixes #210