Skip to content

Constrain estimated viewport. #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 23, 2023
Merged

Conversation

grokys
Copy link
Member

@grokys grokys commented Aug 23, 2023

Our layout code does not expect a viewport with a negative origin. Ensure that EstimateViewport doesn't return one.

Our layout code does not expect a viewport with a negative origin. Ensure that `EstimateViewport` doesn't return one.
@grokys grokys self-assigned this Aug 23, 2023
@danipen danipen self-requested a review August 23, 2023 11:57
Copy link
Collaborator

@danipen danipen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@danipen danipen merged commit 0e68515 into master Aug 23, 2023
@danipen danipen deleted the fixes/estimated-viewport-constraint branch August 23, 2023 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants