-
Notifications
You must be signed in to change notification settings - Fork 66
Improve extensibility #134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
672cde2
to
c3fb825
Compare
maxkatz6
reviewed
Oct 6, 2022
maxkatz6
approved these changes
Oct 7, 2022
grokys
approved these changes
Oct 19, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of nits you may want to fix, but LGTM!
Co-authored-by: Steven Kirk <[email protected]>
auto-merge was automatically disabled
October 19, 2022 15:40
Head branch was pushed to by a user without write access
Co-authored-by: Steven Kirk <[email protected]>
Nits included :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to create a feature for TreeDataGrid and found that it was almost impossible to do it without having at least:
Without those, people like me would have to force the type system beyond reasonable in some scenarios.
Take this as an example:
https://github.com/SuperJMN-Zafiro/Zafiro.Avalonia/blob/master/Zafiro.Avalonia/ScrollToSelectedItemBehavior.cs
As you see, this behavior is not straightforward to use because:
T
, hence the constructor argument that uses reflection on T to get the given property.Sample usage would be:
T
being:With the changes I'm suggesting, the Behavior would stop requiring type parameters and reflection to know how to get the children.
IMHO, this is beneficial from an extensibility standpoint.
I hope you accept these changes :)