Skip to content

Swap tracks linker parameters #90450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 13, 2024

Conversation

robertsreberski
Copy link
Contributor

@robertsreberski robertsreberski commented May 8, 2024

Proposed Changes

Fixes wrong order of params that results in mixed prevuserid and prevuseridtype attributes.

Testing Instructions

  • Enter Jetpack Cloud Live link (in incognito tab)
  • Get tk_ai cookie value from there
  • Enter Calypso Live link (in incognito tab)
  • Using your Calypso Live domain, open <Calypso Live>/checkout/jetpack/jetpack_ai_yearly?_tkl=<tk_ai>
  • Using Tracks Vigilante, notice _aliasUserGeneral event, similar to this one:
    CleanShot 2024-05-08 at 18 02 53@2x

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • https://wpcalypso.wordpress.com/devdocs/docs/testing/index.md for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

Copy link

github-actions bot commented May 8, 2024

@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • blaze-dashboard
  • editing-toolkit
  • happy-blocks
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug fix/tracks-linker-prevuser-parameters-swap on your sandbox.

Copy link
Contributor

@CodeyGuyDylan CodeyGuyDylan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tests as it should as far as I can tell

@robertsreberski robertsreberski merged commit f38108d into trunk May 13, 2024
@robertsreberski robertsreberski deleted the fix/tracks-linker-prevuser-parameters-swap branch May 13, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants