-
Notifications
You must be signed in to change notification settings - Fork 2k
Odie: Update transfer to Happiness message #103765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Conversation
Since Happiness want to manage the messages from Zendesk for more control, let's shorten the transfer message. the transfer message.
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Async-loaded Components (~11 bytes removed 📉 [gzipped])
React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR shortens the user-facing transfer message sent when routing chats to a human agent, removing the reference to “Happiness Engineers” for greater control by the Happiness team.
- Updated the
ODIE_TRANSFER_MESSAGE
constant to a shorter string. - Simplified the translation function call.
Comments suppressed due to low confidence (1)
packages/odie-client/src/constants.ts:32
- Consider adding or updating unit tests or snapshot tests to cover the updated
ODIE_TRANSFER_MESSAGE
string so the change is validated in CI.
content: __( 'No problem. Help is on the way!', __i18n_text_domain__ ),
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/17517424 Some locales (Hebrew) have been temporarily machine-translated due to translator availability. All other translations are usually ready within a few days. Untranslated and machine-translated strings will be sent for translation next Monday and are expected to be completed by the following Friday. Thank you @ehg for including a screenshot in the description! This is really helpful for our translators. |
Closes https://linear.app/a8c/issue/HAL-205
Since Happiness want to manage the messages from Zendesk for more control, let's shorten the transfer message.
Testing Instructions
Pre-merge Checklist