Skip domain step if launch-site triggered from wp-admin #103746

dzver · 2025-05-27T14:31:21Z

Proposed Changes

wp-admin links to start/launch-site for unlaunched sites
When a site already has a domain, we should skip the domain step
When a site completes the flow with or without a purchase of some kind, we should display a message that the site was launched

Why are these changes being made?

wp-admin triggered launch-site doesn't match the one from Calypso

Testing Instructions

Unlaunching a site requires a sandbox - use your site instead of dzver13d

wp option --url=dzver13d.wordpress.com set launch-status unlaunched

Enable the store sandbox
Get a plan AND domain
Go to wp-admin > Settings > Reading and click the button.
Change the wordpress.com address with calypso.localhost:3000
Complete the flow, domain step should be skipped, modal should be displayed
Get a domain but make sure you're on FREE
Repeat steps 4-6, this time you'll be asked to get a plan. No matter which plan you select, completing the flow should display the celebratory modal
You can try the case with plan but no domain just in case

These are the launch buttons in the settings page, they are two and do the same:

This is the modal that's currently only displayed if we launch from Calypso:

Pre-merge Checklist

Has the general commit checklist been followed? (PCYsg-hS-p2)
Have you written new tests for your changes?
Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
Have you checked for TypeScript, React or other console errors?
Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
- For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

github-actions · 2025-05-27T14:31:34Z

Calypso Live (direct link)

	https://calypso.live?image=registry.a8c.com/calypso/app:build-145999

Jetpack Cloud live (direct link)

	https://calypso.live?image=registry.a8c.com/calypso/app:build-145999&env=jetpack

Automattic for Agencies live (direct link)

	https://calypso.live?image=registry.a8c.com/calypso/app:build-145999&env=a8c-for-agencies

matticbot · 2025-05-27T14:33:19Z

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

blaze-dashboard
notifications
wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/launch-site-skip-domain-step-if-domain-present on your sandbox.

matticbot · 2025-05-27T14:36:39Z

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~66 bytes added 📈 [gzipped])

name                        parsed_size           gzip_size
signup                           +231 B  (+0.1%)      +66 B  (+0.1%)
home                             +141 B  (+0.0%)      +47 B  (+0.0%)
async-step-unified-plans         +141 B  (+0.0%)      +47 B  (+0.0%)
async-step-unified-domains       +141 B  (+0.0%)      +47 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

chriskmnds

Tested per the instructions, and it works. Took me ages to test. I haven't tested other flows though, whether this would have any effect on them (I see some more general changes, not launch-site specific). Left a couple of comments for clarity, but otherwise the outlined example tests out.

p.s. This flow will need to migrate to Stepper, so left a relevant comment on that too.

chriskmnds · 2025-05-28T05:42:49Z

client/lib/signup/step-actions/index.js

+	const domainCart = undefined;

-	submitSignupStep( { stepName, domainItem }, { domainItem } );
+	submitSignupStep( { stepName, domainItem }, { domainItem, domainCart } );
 	recordExcludeStepEvent( stepName, tracksEventValue );

-	fulfilledDependencies = [ 'domainItem', 'siteId', 'siteSlug', 'themeItem' ];
+	fulfilledDependencies = [ 'domainItem', 'domainCart' ];


I don't understand what these changes do. Why do we add the undefined domainCart item in the submit-step call?

Boils down to the function with the very-generic name isDomainFulfilled, which is only used for the launch-site flow. If domainCart is not fulfilled, it doesn't exclude the step.

So, why is the domainCart a dependency for the domain step? It doesn't need to be. However, we already have the code for domainItem written this way, and it just doesn't work because of the second dependency. Why undefined - not sure, I followed what's already done for domainItem.

chriskmnds · 2025-05-28T06:29:34Z

client/signup/config/flows.js

+	// Add celebrateLaunch=true for launch-site flow so the celebration modal shows after checkout
+	const isLaunchSiteFlow = flowName === 'launch-site';
+	const finalCheckoutBackUrl = isLaunchSiteFlow
+		? addQueryArgs( { skippedCheckout: 1, celebrateLaunch: 'true' }, checkoutBackUrl )


Would Stepper handle this any differently, meaning without using a query arg? cc @alshakero The logic here and below is it shows a celebratory modal when sent to /home after having launched the site.

Hmm actually, I think maybe it doesn't matter - or come into the picture of "no query args". The way I understand this, the flow itself isn't accepting any args, just sending back with an arg.

chriskmnds · 2025-05-28T06:31:08Z

client/signup/main.jsx

+		// Re-check fulfilled steps when siteDomains data changes
+		// This ensures that isDomainFulfilled is called again when domain data loads
+		if ( siteDomains !== prevProps.siteDomains ) {
+			this.removeFulfilledSteps( this.props );
+		}


Would this affect other flows?

Removing fulfilled steps shouldn't (why would fulfilled steps be still there?) but it might be a good idea to restrict to the launch-site flow to ensure we don't need to test them. Nice find.

dzver requested a review from chriskmnds May 27, 2025 14:31

matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label May 27, 2025

dzver self-assigned this May 27, 2025

chriskmnds reviewed May 28, 2025

View reviewed changes

dzver added 4 commits May 28, 2025 10:25

Skip the domains step from the launch-site flow if domain exists

4971599

Show the post-launch destination

c451cd1

Also show celebration modal if we only buy a domain

928e837

Address concerns in a code review and a cursor glitch

3e6b999

dzver force-pushed the update/launch-site-skip-domain-step-if-domain-present branch from 94e0163 to 3e6b999 Compare May 28, 2025 08:54

dzver merged commit f805210 into trunk May 28, 2025
11 checks passed

dzver deleted the update/launch-site-skip-domain-step-if-domain-present branch May 28, 2025 10:50

github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label May 28, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Skip domain step if launch-site triggered from wp-admin #103746

Skip domain step if launch-site triggered from wp-admin #103746

Uh oh!

dzver commented May 27, 2025

Uh oh!

github-actions bot commented May 27, 2025 •

edited by matticbot

Loading

Uh oh!

matticbot commented May 27, 2025 •

edited

Loading

Uh oh!

matticbot commented May 27, 2025 •

edited

Loading

Uh oh!

chriskmnds left a comment

Uh oh!

chriskmnds May 28, 2025

Uh oh!

dzver May 28, 2025

Uh oh!

chriskmnds May 28, 2025

Uh oh!

chriskmnds May 28, 2025

Uh oh!

chriskmnds May 28, 2025

Uh oh!

dzver May 28, 2025

Uh oh!

Uh oh!

Uh oh!

Skip domain step if launch-site triggered from wp-admin #103746

Skip domain step if launch-site triggered from wp-admin #103746

Uh oh!

Conversation

dzver commented May 27, 2025

Proposed Changes

Why are these changes being made?

Testing Instructions

Pre-merge Checklist

Uh oh!

github-actions bot commented May 27, 2025 • edited by matticbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

matticbot commented May 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

matticbot commented May 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chriskmnds left a comment

Choose a reason for hiding this comment

Uh oh!

chriskmnds May 28, 2025

Choose a reason for hiding this comment

Uh oh!

dzver May 28, 2025

Choose a reason for hiding this comment

Uh oh!

chriskmnds May 28, 2025

Choose a reason for hiding this comment

Uh oh!

chriskmnds May 28, 2025

Choose a reason for hiding this comment

Uh oh!

chriskmnds May 28, 2025

Choose a reason for hiding this comment

Uh oh!

dzver May 28, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented May 27, 2025 •

edited by matticbot

Loading

matticbot commented May 27, 2025 •

edited

Loading

matticbot commented May 27, 2025 •

edited

Loading