Calendar components: simplify types, forward all onChange arguments

[ciampo]

Closes DS-232

Proposed Changes

• Remove type unions around the required prop.
• Forward onChange arguments in the useControlledValue hook

Why are these changes being made?

The current type unions complicate the code without necessarily bringing better DX. Removing them allows us to simplify the code, and generalize the useControlledValue hook.

The arguments forwarding for the onChange callback in useControlledValue also fixes an inconsistency, where the onSelect callback prop would return extra arguments only in uncontrolled mode.

Testing Instructions

• No TS errors
• DateCalendar and DateRangeCalendar works as expected in Storybook

Pre-merge Checklist

• Has the general commit checklist been followed? (PCYsg-hS-p2)
• Have you written new tests for your changes?
• Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
• Have you checked for TypeScript, React or other console errors?
• Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
• Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
• For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

[github-actions]

Calypso Live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-145736

Jetpack Cloud live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-145736&env=jetpack

Automattic for Agencies live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-145736&env=a8c-for-agencies

[matticbot]

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

• help-center

To test WordPress.com changes, run install-plugin.sh $pluginSlug feat/calendar-simplify-types on your sandbox.

[matticbot]

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

[tyxla]

LGTM, thanks for the cleanup 👍

[tyxla]

Nit: do we care about WP-style spacing in these kinds of examples?

[ciampo]

E2E can't be caused by the changes in this PR since they are not exported from the package (and used anywhere)