Skip to content

Reader - logged out show post to navigate to full post view / signup #103641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 23, 2025

Conversation

Addison-Stavlo
Copy link
Contributor

Part of # https://linear.app/a8c/issue/CML-459/reader-discover-page-logged-out-users-are-directed-out-of-reader-when / #101686

Proposed Changes

  • Removes logged out check from showSelectedPost util, so we will no longer redirect out to the external blog when not logged in.

Why are these changes being made?

  • Prompt logged out users to signup/login and use the full reader features.

Testing Instructions

  • Go to the reader logged out
  • Click a post in a stream, verify you are not directed to the blog but signup/signin
  • after signup/signin, verify you are on the full post view of the post you clicked
  • Test clicking cards logged in, verify no regressions.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@Addison-Stavlo Addison-Stavlo self-assigned this May 22, 2025
@Addison-Stavlo Addison-Stavlo requested a review from a team as a code owner May 22, 2025 16:41
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label May 22, 2025
Copy link

github-actions bot commented May 22, 2025

@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • blaze-dashboard
  • command-palette-wp-admin
  • help-center
  • notifications
  • odyssey-stats
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug fix/logged-out-reader-full-post-redirect on your sandbox.

@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~18 bytes removed 📉 [gzipped])

name    parsed_size           gzip_size
reader       -102 B  (-0.0%)      -18 B  (-0.0%)
home         -102 B  (-0.0%)      -18 B  (-0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~18 bytes removed 📉 [gzipped])

name                                                 parsed_size           gzip_size
async-load-design-blocks                                  -102 B  (-0.0%)      -18 B  (-0.0%)
async-load-calypso-components-web-preview-component       -102 B  (-0.0%)      -18 B  (-0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Member

@allilevine allilevine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks so much better when signing up 🙌 I didn't see any regressions.

@Addison-Stavlo Addison-Stavlo merged commit 1d89c63 into trunk May 23, 2025
13 checks passed
@Addison-Stavlo Addison-Stavlo deleted the fix/logged-out-reader-full-post-redirect branch May 23, 2025 10:23
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label May 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants