-
Notifications
You must be signed in to change notification settings - Fork 2k
Remove color override from stepper nav top bar right element #103610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
This PR does not affect the size of JS and CSS bundles shipped to the user's browser. Generated by performance advisor bot at iscalypsofastyet.com. |
@zaerl could you please confirm that this fixes your issue 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR! The dark color is actually intentional as far as the current onboarding designs, though in those designs it should be $gray-900. But this effort, in crossing boundaries across the products, does surface some pushback on that design. To that end, I'd love a broader glance and feedback by @Automattic/dotcom-design before you land this. |
Part of DSGCOM-92: Update primary buttons on 'Continue as user'
Proposed Changes
Why are these changes being made?
Overrides to the design system should be avoided, see discussion.
Testing Instructions
Screenshots
Pre-merge Checklist