Skip to content

Bump up the resource class for WP Desktop Linux #103534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

twstokes
Copy link
Contributor

@twstokes twstokes commented May 19, 2025

Proposed Changes

Why are these changes being made?

  • To resolve the following error when CI runs the build:
➤ YN0000: · Yarn 4.0.2
➤ YN0000: ┌ Resolution step
➤ YN0000: └ Completed in 0s 791ms
➤ YN0000: ┌ Fetch step

Exited with code exit status 137

Similarly to what we've done before.

Testing Instructions

  • Check that wp-desktop-linux ran successfully in CI.

@twstokes twstokes added the [Type] Tooling Related to tools, scripts, automation, DevX, etc. label May 19, 2025
@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug ci/wp-desktop-linux on your sandbox.

@@ -268,7 +268,7 @@ jobs:
# version to keep this one working for now.
- image: cimg/node:22.9.0-browsers
<<: *desktop_defaults
resource_class: medium+
resource_class: large
Copy link

@iangmaia iangmaia May 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another thing to try out is to set in the env var NODE_OPTIONS to something like --max-old-space-size=4096 (or more if needed).

Copy link
Contributor Author

@twstokes twstokes May 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iangmaia does this feel like the better thing to do since it failed on the Yarn / Node step? Last time we considered jumping straight to large, but staying with medium+ would prevent extra costs. What are your thoughts?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can try just using NODE_OPTIONS (on a 6GB machine, setting it to 5120 probably makes sense based on the documentation), but increasing the resource_class might still be needed if that doesn't work; I guess we need to try it out.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good. I'll do NODE_OPTIONS first. Thanks!

@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@twstokes twstokes marked this pull request as ready for review May 19, 2025 17:27
@twstokes
Copy link
Contributor Author

Looks like I'll need to adjust the branch name for this job to run.

@twstokes twstokes closed this May 19, 2025
@twstokes twstokes deleted the ci/wp-desktop-linux branch May 19, 2025 17:40
@twstokes
Copy link
Contributor Author

Replaced by #103535.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Tooling Related to tools, scripts, automation, DevX, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants