-
Notifications
You must be signed in to change notification settings - Fork 2k
Bump up the resource class for WP Desktop Linux #103534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
@@ -268,7 +268,7 @@ jobs: | |||
# version to keep this one working for now. | |||
- image: cimg/node:22.9.0-browsers | |||
<<: *desktop_defaults | |||
resource_class: medium+ | |||
resource_class: large |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another thing to try out is to set in the env var NODE_OPTIONS
to something like --max-old-space-size=4096
(or more if needed).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@iangmaia does this feel like the better thing to do since it failed on the Yarn / Node step? Last time we considered jumping straight to large
, but staying with medium+
would prevent extra costs. What are your thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can try just using NODE_OPTIONS
(on a 6GB machine, setting it to 5120
probably makes sense based on the documentation), but increasing the resource_class
might still be needed if that doesn't work; I guess we need to try it out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good. I'll do NODE_OPTIONS
first. Thanks!
This PR does not affect the size of JS and CSS bundles shipped to the user's browser. Generated by performance advisor bot at iscalypsofastyet.com. |
Looks like I'll need to adjust the branch name for this job to run. |
Replaced by #103535. |
Proposed Changes
Why are these changes being made?
Similarly to what we've done before.
Testing Instructions