Skip to content

Domain connection setup: Show @ for root domains and remove fqdn for subdomains #103533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 20, 2025

Conversation

gius80
Copy link
Contributor

@gius80 gius80 commented May 19, 2025

Part of https://linear.app/a8c/issue/NOMADO-169/update-the-name-texts-on-the-advanced-domain-connection-setup-screen

Proposed Changes

This PR improves the domain connection experience by correcting how DNS records are displayed in the advanced setup for both root domains and subdomains:

  • For root domains, A records now display "@" instead of the full domain name.
  • For subdomains, A records now display only the subdomain part.
  • For subdomains, the CNAME record for www now displays only the subdomain part, prefixed with www.

Why are these changes being made?

These changes enhance the domain connection process by ensuring DNS record formats are accurate for both root domains and subdomains. Most popular domain registrars (including ours) automatically append the domain name when configuring A or CNAME records. As a result, displaying the full domain previously led less technical users to mistakenly create records like domain.ext.domain.ext, causing connection issues and user frustration.

Domains
BEFORE AFTER
Subdomains
BEFORE AFTER

Testing Instructions

This PR depends on this backend update: 183202-ghe-Automattic/wpcom

  • Connect a new domain, then follow the advance setup and verify that the A records name show @ instead of the domain name.
  • Now test a subdomain connection. The A name records should show the subdomain part and the CNAME should show www + subdomain part.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@gius80 gius80 self-assigned this May 19, 2025
Copy link

github-actions bot commented May 19, 2025

@matticbot
Copy link
Contributor

matticbot commented May 19, 2025

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~69 bytes added 📈 [gzipped])

name                        parsed_size           gzip_size
domains                          +114 B  (+0.0%)      +69 B  (+0.0%)
async-step-use-my-domain         +114 B  (+0.0%)      +69 B  (+0.0%)
async-step-unified-domains       +114 B  (+0.0%)      +69 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~69 bytes added 📈 [gzipped])

name                             parsed_size           gzip_size
async-load-signup-steps-domains       +114 B  (+0.0%)      +69 B  (+0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@gius80 gius80 marked this pull request as ready for review May 19, 2025 15:26
@gius80 gius80 changed the title Show @ for root domains and remove fqdn for subdomains Domain connection setup: Show @ for root domains and remove fqdn for subdomains May 19, 2025
Copy link
Contributor

@leonardost leonardost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with the corresponding WPCOM PR and LGTM! Thanks for this update!

@gius80 gius80 force-pushed the update/connect-domain-advance-setup-records branch from b1a9ee2 to 75c0065 Compare May 20, 2025 08:02
@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • blaze-dashboard
  • command-palette-wp-admin
  • help-center
  • notifications
  • odyssey-stats
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/connect-domain-advance-setup-records on your sandbox.

@gius80 gius80 merged commit b04945b into trunk May 20, 2025
11 checks passed
@gius80 gius80 deleted the update/connect-domain-advance-setup-records branch May 20, 2025 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants