Skip to content

Akismet checkout: Copy updates for quantity option labels #103509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

aperdomo
Copy link

Resolves SAFE-90

Proposed Changes

  • This PR nudges the copy for the Akismet pro plan's quantity options.

Why are these changes being made?

  • These are being changed for consistency with options that will also appear on the akismet.com/pricing page.
    • Related to SAFE-88
BEFORE AFTER
before after

Testing Instructions

  • Open the calypso.live link in the comments below
  • Navigate to /checkout/akismet/ak_pro5h_yearly
  • Note that the copy changes are reflected.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@aperdomo aperdomo requested a review from a team as a code owner May 16, 2025 18:34
@aperdomo aperdomo added [Status] String Freeze Add the [Status] String Freeze label to your PR to ensure new strings are translated before merging Akismet labels May 16, 2025
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label May 16, 2025
@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~35 bytes added 📈 [gzipped])

name                     parsed_size           gzip_size
checkout                      +103 B  (+0.0%)      +35 B  (+0.0%)
a8c-for-agencies-client       +103 B  (+0.0%)      +35 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@aperdomo aperdomo requested a review from lschuyler May 16, 2025 18:44
@a8ci18n
Copy link

a8ci18n commented May 16, 2025

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/17482793

Some locales (Brazilian Portuguese, Hebrew, Japanese) have been temporarily machine-translated due to translator availability. All other translations are usually ready within a few days. Untranslated and machine-translated strings will be sent for translation next Monday and are expected to be completed by the following Friday.

Thank you @aperdomo for including a screenshot in the description! This is really helpful for our translators.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Akismet [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Status] String Freeze Add the [Status] String Freeze label to your PR to ensure new strings are translated before merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants