Language Switcher: Replace custom Dialog component with the core Modal. #103503

sdnunca · 2025-05-16T16:00:48Z

Fixes DOTCOM-12873

Proposed Changes

Replace the Dialog component with the core's Modal.

Why are these changes being made?

The previous modal was unnecessarily large.

Before:

After:

Testing Instructions

Visit /me/account, open the language switcher modal, and confirm it works correctly.

Pre-merge Checklist

Has the general commit checklist been followed? (PCYsg-hS-p2)
Have you written new tests for your changes?
Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
Have you checked for TypeScript, React or other console errors?
Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
- For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

github-actions · 2025-05-16T16:01:04Z

Calypso Live (direct link)

	https://calypso.live?image=registry.a8c.com/calypso/app:build-144712

Jetpack Cloud live (direct link)

	https://calypso.live?image=registry.a8c.com/calypso/app:build-144712&env=jetpack

Automattic for Agencies live (direct link)

	https://calypso.live?image=registry.a8c.com/calypso/app:build-144712&env=a8c-for-agencies

matticbot · 2025-05-16T16:04:12Z

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~31 bytes added 📈 [gzipped])

name                   parsed_size           gzip_size
entry-main                  +370 B  (+0.0%)       +1 B  (+0.0%)
entry-login                 +370 B  (+0.0%)      +30 B  (+0.0%)
entry-reauth-required       +185 B  (+0.0%)       +0 B

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~14 bytes added 📈 [gzipped])

name      parsed_size           gzip_size
settings        +92 B  (+0.0%)      -10 B  (-0.0%)
plugins         +92 B  (+0.0%)       +3 B  (+0.0%)
media           +92 B  (+0.0%)       +3 B  (+0.0%)
account         +92 B  (+0.0%)      +21 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~349 bytes added 📈 [gzipped])

name                                            parsed_size            gzip_size
async-load-calypso-lib-account-settings-helper     +16375 B  (+14.2%)    +5765 B  (+16.0%)
async-load-quick-language-switcher                 +16362 B  (+26.1%)    +5773 B  (+27.2%)
async-load-design-playground                          +92 B   (+0.0%)       +3 B   (+0.0%)
async-load-design-blocks                              +92 B   (+0.0%)       +3 B   (+0.0%)
async-load-design                                     +92 B   (+0.0%)       +3 B   (+0.0%)
async-load-calypso-post-editor-media-modal            +92 B   (+0.0%)       +3 B   (+0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

client/components/language-picker/modal.tsx

matticbot · 2025-05-16T16:56:40Z

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

blaze-dashboard
command-palette-wp-admin
help-center
notifications
odyssey-stats
wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/switch-language-switcher-to-core-modal on your sandbox.

chriskmnds

Tested and it works! Left some code comments below.

chriskmnds · 2025-05-16T17:03:39Z

client/components/language-picker/modal.scss

+		flex:none;
+		flex-direction: column;
+		width: 100%;
+		>div:nth-child(2) {


What are we targeting with this? Can we add a comment, or is there another way to be more explicit/clear? 🤔

I've added a comment, unfortunately, there's no easy way to add a class to the Modal HTML structure.

Heya. Replied below - #103503 (comment)
Let me know if you'll be confirming that, otherwise happy to explore further myself. :)

Yep, I'm currently addressing the reported issues.

Sounds good. Happy to review any additional changes.

chriskmnds · 2025-05-16T17:06:14Z

client/components/language-picker/modal.scss

+		display:flex;
+		flex:none;
+		flex-direction: column;
+		width: 100%;


Sorry for naive question. Are these effective/needed?

Thanks, with flex:none not being needed, I've removed the three instructions.

Seems to be a leftover from my previous attempt.

I wonder if removing any of these caused the breakage in #103503 (comment)

chriskmnds · 2025-05-19T08:53:14Z

I think some design is broken, or not fixed/ made worse.

This doesn't look ideal:

It was a little better before, but still modal too far stretched out.

Can you pls confirm?

chriskmnds · 2025-05-19T09:09:53Z

client/components/language-picker/modal.scss

+		display:flex;
+		/* Targeting the content div, we can't alter the HTML of the modal itself */
+		>div:nth-child(2) {
+			height: 100%;


Does height: 100% have any actual effect right now?

Sorry for my questions. CSS is not trivial to maintain.

chriskmnds · 2025-05-19T09:27:51Z

client/components/language-picker/modal.scss

+		margin-top: 24px;
+		display:flex;
+		/* Targeting the content div, we can't alter the HTML of the modal itself */
+		>div:nth-child(2) {


In general, I think the more we can avoid referencing internal structures of external components, the better. These may change, even the core class names may change e.g. components-modal__content.

In this case, it looks we can achieve the same effect by wrapping the content we pass to the modal and target that instead, e.g.

<div className="language-picker__modal-content"> <LanguagePicker headingTitle={ __( 'Select a language' ) } languages={ languages } languageGroups={ createLanguageGroups( __ ) } onSelectLanguage={ setSelectedLanguage } selectedLanguage={ selectedLanguage } localizedLanguageNames={ localizedLanguageNames } /> <div>{ buttons }</div> </div>

Targeting language-picker__modal-content would be safe(r).

But pls confirm. I only briefly tested.

We can drill into the need to even reference components-modal__content separately. That may be able to go away too.

sdnunca · 2025-05-19T09:39:25Z

Thanks for the report @chriskmnds, I'm currently addressing the issues, will have a PR up soon.

Language Switcher: Replace custom Dialog component with the core Modal.

3dd0e8d

sdnunca requested a review from a team as a code owner May 16, 2025 16:00

matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label May 16, 2025

sdnunca requested a review from a team May 16, 2025 16:01

chriskmnds reviewed May 16, 2025

View reviewed changes

client/components/language-picker/modal.tsx Outdated Show resolved Hide resolved

Remove superfluous class.

e1e2d89

sdnunca requested a review from a team May 16, 2025 16:51

chriskmnds reviewed May 16, 2025

View reviewed changes

Remove flex:none.

75dec3e

sdnunca merged commit aa01b6a into trunk May 18, 2025
13 of 14 checks passed

sdnunca deleted the update/switch-language-switcher-to-core-modal branch May 18, 2025 21:02

github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label May 18, 2025

chriskmnds reviewed May 19, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Language Switcher: Replace custom Dialog component with the core Modal. #103503

Language Switcher: Replace custom Dialog component with the core Modal. #103503

sdnunca commented May 16, 2025 •

edited

Loading

github-actions bot commented May 16, 2025 •

edited by matticbot

Loading

matticbot commented May 16, 2025 •

edited

Loading

matticbot commented May 16, 2025 •

edited

Loading

chriskmnds left a comment

chriskmnds May 16, 2025

sdnunca May 17, 2025

chriskmnds May 19, 2025

sdnunca May 19, 2025

chriskmnds May 19, 2025

chriskmnds May 16, 2025

sdnunca May 17, 2025

chriskmnds May 19, 2025

chriskmnds commented May 19, 2025

chriskmnds May 19, 2025

chriskmnds May 19, 2025 •

edited

Loading

sdnunca commented May 19, 2025

Language Switcher: Replace custom Dialog component with the core Modal. #103503

Language Switcher: Replace custom Dialog component with the core Modal. #103503

Conversation

sdnunca commented May 16, 2025 • edited Loading

Proposed Changes

Why are these changes being made?

Testing Instructions

Pre-merge Checklist

github-actions bot commented May 16, 2025 • edited by matticbot Loading

matticbot commented May 16, 2025 • edited Loading

matticbot commented May 16, 2025 • edited Loading

chriskmnds left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

chriskmnds commented May 19, 2025

Choose a reason for hiding this comment

chriskmnds May 19, 2025 • edited Loading

Choose a reason for hiding this comment

sdnunca commented May 19, 2025

sdnunca commented May 16, 2025 •

edited

Loading

github-actions bot commented May 16, 2025 •

edited by matticbot

Loading

matticbot commented May 16, 2025 •

edited

Loading

matticbot commented May 16, 2025 •

edited

Loading

chriskmnds May 19, 2025 •

edited

Loading