Pass siteSlug as component prop instead of using router instances

[taipeicoder]

Proposed Changes

This PR passes siteSlug as component prop from the router, instead of explicitly using path-specific route instances within components. This change allows the components to decouple from route instances, making them reusable in the case of backporting where another router instance is used.

Why are these changes being made?

Decouple components from route instances.

Testing Instructions

• Head to /v2/sites/:site/settings/
• Navigate to settings such as site visibility and gift subscription, and ensure that they still work as intended.

Pre-merge Checklist

• Has the general commit checklist been followed? (PCYsg-hS-p2)
• Have you written new tests for your changes?
• Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
• Have you checked for TypeScript, React or other console errors?
• Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
• Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
• For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

[github-actions]

Calypso Live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-144710

Jetpack Cloud live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-144710&env=jetpack

Automattic for Agencies live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-144710&env=a8c-for-agencies

[matticbot]

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~29 bytes added 📈 [gzipped])

name                    parsed_size           gzip_size
entry-dashboard-dotcom       +124 B  (+0.0%)      +14 B  (+0.0%)
entry-dashboard-a4a          +124 B  (+0.0%)      +15 B  (+0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

[taipeicoder]

strict: false is needed otherwise useParams throws an error saying that the param from is needed. Adding the from defeats the purpose of this PR since it's the route path.

[youknowriad]

This makes sense to me. Thanks

[youknowriad]

So just for clarify, we lose the "types" here right? Doesn't seem like a big problem right now but we might want to restore "from" later if reusability of these components is not needed anymore.

The other possibility is to actually reuse UI components, the "route" component become just wrappers.

[taipeicoder]

@youknowriad I ended up passing siteSlug as a props component from the router instead of using router instances. Let me know if there are concerns with this approach, thanks.

[matticbot]

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

• blaze-dashboard
• command-palette-wp-admin
• help-center
• notifications
• odyssey-stats
• wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/use-params-with-strict-false on your sandbox.

[youknowriad]

It works for me :)