-
Notifications
You must be signed in to change notification settings - Fork 2k
DataForm: implement toggleGroup Edit control #103483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
@@ -0,0 +1,56 @@ | |||
/** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is almost a verbatim copy of the existing radio control, with some modifications.
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~79 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
This is great, thank you. I left a comment about camelCase vs kebab-case, and I think we should prefer the former unless there's any specific reason for the choice. This works well, and it's ready to land in my view. Just for awareness, when working with DataForm we need to test a few configurations: type of form (regular or panel) and label position (top, side, none): Screen.Recording.2025-05-16.at.10.52.41.mov |
Yup, I did. 😄 |
Nice, thank you. I wasn't aware if you were aware, so I thought it'd be best to over-communicate just in case. :) |
c075eaf
to
6431eef
Compare
Related to #103426 (comment)
Proposed Changes
This PR introduces a new
Edit
control,toggleGroup
, to DataForm fields.Testing Instructions
yarn workspace @automattic/dataviews storybook:start
Status
field which uses the newtoggleGroup
control.Pre-merge Checklist