Skip to content

Revert "Experiment streamlining the plans grid + checkout: Update the plan interval dropdown" #103481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

claudiucelfilip
Copy link
Contributor

@claudiucelfilip claudiucelfilip commented May 16, 2025

Reverts #103418

This revert addresses a layout issue on the control version of the dropdown selector:
Screenshot 2025-05-16 at 10 06 21

@claudiucelfilip claudiucelfilip requested a review from a team as a code owner May 16, 2025 06:36
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label May 16, 2025
Copy link

github-actions bot commented May 16, 2025

@claudiucelfilip claudiucelfilip merged commit cc470a1 into trunk May 16, 2025
13 of 16 checks passed
@claudiucelfilip claudiucelfilip deleted the revert-103418-update/streamlined-pricing-experiment-dropdown branch May 16, 2025 06:45
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label May 16, 2025
@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~737 bytes removed 📉 [gzipped])

name                      parsed_size           gzip_size
checkout                      -2438 B  (-0.1%)     -724 B  (-0.1%)
a8c-for-agencies-client       -2438 B  (-0.1%)     -724 B  (-0.1%)
plugins                         -66 B  (-0.0%)      -13 B  (-0.0%)
plans                           -66 B  (-0.0%)      -13 B  (-0.0%)
jetpack-app                     -66 B  (-0.0%)      -13 B  (-0.0%)
async-step-unified-plans        -66 B  (-0.0%)      -13 B  (-0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~30 bytes removed 📉 [gzipped])

name                                                                              parsed_size           gzip_size
async-load-signup-steps-plans-theme-preselected                                         -66 B  (-0.0%)      -13 B  (-0.0%)
async-load-signup-steps-plans                                                           -66 B  (-0.0%)      -13 B  (-0.0%)
async-load-signup-steps-page-picker                                                     -66 B  (-0.0%)      -17 B  (-0.0%)
async-load-purchase-modal-wrapper                                                       -66 B  (-0.0%)      -17 B  (-0.0%)
async-load-my-sites-checkout-purchase-modal-is-eligible-for-one-click-checkou...        -66 B  (-0.0%)      -17 B  (-0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants