Skip to content

Domains: fix help link to point to domains privacy page, props donalirl #103475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

lancewillett
Copy link
Contributor

Props @donalirl

Context
Edit a domain and open the Contact Information panel. Click the "learn more" link.

It opens: https://wordpress.com/support/domains/register-domain/#public-versus-private-registration-and-gdpr

It should open: https://wordpress.com/support/domains/domain-registrations-and-privacy/

Impact: The new link has more information about privacy protection than the current link, so this update will be more helpful to users.

Copy link

github-actions bot commented May 15, 2025

@lancewillett lancewillett added Quick Fix [Feature] Support Links Links to support documentation around Calypso labels May 15, 2025
@lancewillett lancewillett requested a review from sejas May 15, 2025 20:29
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label May 15, 2025
@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • blaze-dashboard
  • help-center
  • notifications

To test WordPress.com changes, run install-plugin.sh $pluginSlug fix/dotcom-13122-domain-settings-contact-information-update-learn-more-link on your sandbox.

@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Async-loaded Components (~9 bytes removed 📉 [gzipped])

name                      parsed_size           gzip_size
async-load-context-links        -13 B  (-0.1%)       -9 B  (-0.3%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@lancewillett
Copy link
Contributor Author

Tested in Calypso.live and works as expected.

Screenshot 2025-05-15 at 13 47 27

@lancewillett lancewillett merged commit 3af5bdb into trunk May 15, 2025
15 of 19 checks passed
@lancewillett lancewillett deleted the fix/dotcom-13122-domain-settings-contact-information-update-learn-more-link branch May 15, 2025 20:48
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label May 15, 2025
@lancewillett lancewillett removed the request for review from sejas May 15, 2025 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Domains UI [Feature] Support Links Links to support documentation around Calypso Quick Fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants