Skip to content

Upgrade Playground dependencies #103474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 15, 2025
Merged

Upgrade Playground dependencies #103474

merged 1 commit into from
May 15, 2025

Conversation

aduth
Copy link
Member

@aduth aduth commented May 15, 2025

Proposed Changes

  • Upgrades @wp-playground/client to the latest version
  • Removes @wp-playground/blueprints direct dependency (still an indirect dependency), since we're using it for a single TypeScript type already provided through @wp-playground/client

Why are these changes being made?

  • Improve build stability and install times. As discussed in Slack (p1746787702918969-slack-C02DQP0FP), the way these dependencies were packaged inflated their size unnecessarily, resulting in a total size of over 750 MB. With the latest version, this is down to ~200MB, with the bulk of size coming from compiled WASM.

Testing Instructions

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

Copy link

github-actions bot commented May 15, 2025

@aduth aduth requested review from simison, brandonpayton and a team May 15, 2025 17:19
@matticbot matticbot added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels May 15, 2025
@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~336 bytes added 📈 [gzipped])

name                        parsed_size           gzip_size
stepper-user-step               +1042 B  (+0.1%)     +336 B  (+0.2%)
jetpack-connect                 +1042 B  (+0.1%)     +336 B  (+0.1%)
async-step-unified-plans        +1042 B  (+0.1%)     +336 B  (+0.1%)
async-step-unified-domains      +1042 B  (+0.1%)     +336 B  (+0.1%)
accept-invite                   +1042 B  (+0.2%)     +336 B  (+0.2%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~336 bytes added 📈 [gzipped])

name                             parsed_size           gzip_size
async-load-signup-steps-user         +1042 B  (+0.1%)     +336 B  (+0.2%)
async-load-signup-steps-domains      +1042 B  (+0.1%)     +336 B  (+0.1%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@aduth aduth requested a review from zaerl May 15, 2025 17:24
Copy link
Contributor

@zaerl zaerl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working as expected. 🚢

@aduth aduth merged commit 9d65c20 into trunk May 15, 2025
16 of 17 checks passed
@aduth aduth deleted the update/wp-playground-deps branch May 15, 2025 19:06
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label May 15, 2025
@simison simison removed their request for review May 16, 2025 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants