Skip to content

Backport Site Settings v2 to existing dashboard #103368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: trunk
Choose a base branch
from

Conversation

taipeicoder
Copy link
Contributor

Part of #

Proposed Changes

Why are these changes being made?

Testing Instructions

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@matticbot
Copy link
Contributor

matticbot commented May 13, 2025

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~1594 bytes added 📈 [gzipped])

name                    parsed_size           gzip_size
entry-main                  +1594 B  (+0.1%)     +354 B  (+0.1%)
entry-subscriptions         +1378 B  (+0.1%)     +368 B  (+0.1%)
entry-stepper               +1378 B  (+0.1%)     +371 B  (+0.1%)
entry-reauth-required       +1378 B  (+0.1%)     +368 B  (+0.1%)
entry-login                 +1378 B  (+0.1%)     +368 B  (+0.1%)
entry-domains-landing       +1378 B  (+0.2%)     +368 B  (+0.2%)
entry-browsehappy           +1378 B  (+0.7%)     +368 B  (+0.6%)
entry-dashboard-dotcom       +996 B  (+0.1%)    +1578 B  (+0.5%)
entry-dashboard-a4a          +996 B  (+0.1%)    +1575 B  (+0.5%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~26758 bytes added 📈 [gzipped])

name           parsed_size           gzip_size
site-settings     +85499 B  (+6.2%)   +25120 B  (+6.4%)
hosting           +85377 B  (+5.3%)   +25093 B  (+5.5%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@taipeicoder taipeicoder self-assigned this May 13, 2025
@taipeicoder taipeicoder force-pushed the try/backport-site-settings-v2 branch 2 times, most recently from 6df002c to df30b9a Compare May 17, 2025 03:03
@taipeicoder taipeicoder force-pushed the try/backport-site-settings-v2 branch from df30b9a to 4b6294d Compare May 19, 2025 02:02
@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • help-center
  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug try/backport-site-settings-v2 on your sandbox.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants