-
Notifications
You must be signed in to change notification settings - Fork 2k
Update plugin meta details. #103364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update plugin meta details. #103364
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~436 bytes removed 📉 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Async-loaded Components (~65 bytes added 📈 [gzipped])
React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
For /plugins/woocommerce-xero I'm seeing: With a link to https://wordpress.org/support/plugin/woocommerce-xero/reviews which is a 404 page. |
@taipeicoder Thanks for catching that. I'll do more thorough testing. |
Yep, didn't realize we had two review flows. Shortsighted on my part. 🙇♂️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left minor feedback, overall it looks good 👍
@fditrapani I want to call out that I'm not displaying the decimals for integers, so for example: To me, that seems more natural, however, it does take it out of sync with the card which displays the rating as
Thoughts? |
No worries!
I think that's a good call too. Any chance we can sync up the other view so that we don't have 2 different treatments? |
02921f7
to
4b78af2
Compare
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
@fditrapani I've updated the cards to match. Can you check that and advise as to whether this is ready to merge. Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! thanks for the updates. Looking good 😎
@@ -42,9 +42,10 @@ const PluginDetailsHeader = ( { | |||
} ); | |||
|
|||
// Rating can be a valid number, 0 or null, discard undefined for easier comparison | |||
const rating = isMarketplaceProduct | |||
? ( reviewsStats?.ratings_average * 100 ) / 5 ?? 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This, reviewsStats?.ratings_average
will return NaN
for marketplace ratings as reviewsStats
hasn't been resolved yet. This results in a brief flash of null
in the view.
Part of #100453
Figma: Qtuh9uDXchizLRdGio68gk-fi-1_2046
Proposed Changes
This PR updates the Plugin Meta details to match the designs.
Changes:
<PluginRatings/>
<PluginsBrowserListElement>
.TODO:
The designs include a copy update from "Active installations" to "Installations".That is very specific terminology from wp.org that I want confirmation on before making the change.Comment: Qtuh9uDXchizLRdGio68gk-fi-1_2354#1252967774Screenshots
Why are these changes being made?
We are no longer displaying star ratings.
Considerations
This PR removes a lot of functionality from
<PluginRatings />
. I've searched the code base and found no other use of this component anywhere, and most of the features were not being used.If this isn't the right way to process, I can revert.
Testing Instructions
Plugin with reviews
On a free site, find a plugin with no reviews. Expect it to look like the screenshot above.
Plugin with no reviews
On a free site, find a plugin with no reviews. Expect it to look like the screenshot above.
Pre-merge Checklist