-
Notifications
You must be signed in to change notification settings - Fork 2k
Add scape char to percentage symbol #103361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
This PR does not affect the size of JS and CSS bundles shipped to the user's browser. Generated by performance advisor bot at iscalypsofastyet.com. |
This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/17462706 Some locales (Hebrew) have been temporarily machine-translated due to translator availability. All other translations are usually ready within a few days. Untranslated and machine-translated strings will be sent for translation next Monday and are expected to be completed by the following Friday. Thank you @andres-blanco for including a screenshot in the description! This is really helpful for our translators. |
Translation for this Pull Request has now been finished. |
79d51cc
to
9262f48
Compare
9262f48
to
9df37c1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Closes DOTCON-45
Proposed Changes
Scape the percentage symbol so it's correctly ignored when interpolating. This should be merged once all the translations are ready and the string displays correctly in all languages.
Why are these changes being made?
On languages different than English this string is producing an unexpected translation.
Current translation looks like:

Since the
%
is a reserved character for interpolation, we need to scape it so it's dealt with correctly when translating.Testing Instructions
NOTE: this will only work when the translation for the new string with the scaped % exists
/setup/site-migration/site-migration-how-to-migrate
Pre-merge Checklist