Skip to content

Showing Continue button after having a domain in the cart when coming from /new-hosted-site flow #103359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 13, 2025
Merged

Showing Continue button after having a domain in the cart when coming from /new-hosted-site flow #103359

merged 1 commit into from
May 13, 2025

Conversation

paulopmt1
Copy link
Contributor

@paulopmt1 paulopmt1 commented May 12, 2025 •
edited
Loading

Related to https://linear.app/a8c/issue/DOTCOM-13094/showing-continue-button-at-the-domains-page-for-new-hosted-site-flow

Proposed Changes

  • Showing the mini cart for users coming from the /new-hosted-site flow so they can see the Continue button there

Why are these changes being made?

  • Reported here (p1746552097987089-slack-C029GN3KD), we want to have a good usability while we're revamping the domain page.

Testing Instructions

image

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@github-actions GitHub Actions
Copy link

github-actions bot commented May 12, 2025 •
edited by matticbot
Loading

Calypso Live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-143918
Jetpack Cloud live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-143918&env=jetpack
Automattic for Agencies live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-143918&env=a8c-for-agencies

@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • help-center
  • notifications

To test WordPress.com changes, run install-plugin.sh $pluginSlug fix/showing-continue-button-on-hosting-domains-page on your sandbox.

@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@paulopmt1 paulopmt1 requested a review from a team May 12, 2025 19:05
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label May 12, 2025
@paulopmt1 paulopmt1 requested a review from a team May 12, 2025 19:05
bogiii
bogiii approved these changes May 12, 2025
View reviewed changes
Copy link
Contributor

@bogiii bogiii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as described. 👍

@paulopmt1 paulopmt1 merged commit f3820b0 into trunk May 13, 2025
17 checks passed
@paulopmt1 paulopmt1 deleted the fix/showing-continue-button-on-hosting-domains-page branch May 13, 2025 12:15
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label May 13, 2025
paulopmt1 added a commit that referenced this pull request May 13, 2025
@paulopmt1
Revert "Showing multiple domain selection on new-hosted-site flow (#1…
147cf92 
…03359)"

This reverts commit f3820b0.
This was referenced May 13, 2025
Closed
Merged
kangzj pushed a commit that referenced this pull request May 13, 2025
@paulopmt1 @kangzj
Showing multiple domain selection on new-hosted-site flow (#103359)
f4dffd8
kangzj added a commit that referenced this pull request May 13, 2025
@kangzj @Nikschavan
@dognose24 @tellthemachines @aduth @tyxla @ntsekouras @ciampo @wojtekn @paulopmt1 @bogiii @jsnajdr @andres-blanco @CGastrell @valterlorran @arthur791004 @sdnunca
Stats: Release Navigation Improvements (#103367)
c02ca66 
* flip the flag

* Fix stats-navigation tab selectors for tests

* Stats: Fix e2e tests by handling new selectors for the new nav header (#103384)

* Add a new utility function for clicking on new navigation

* Handle selectors for the new navigation header in e2e tests

* Don't update the selector for other tests apart from stats

* Adjust styling for summary nav on mobile (#103363)

* Remove `preventWidows` from `client/components` (#103187)

* Remove `preventWidows` from `client/components`

* CardHeading

* VisibleDaysLimitUpsell

* Add new site for A4A and add styles

* Remove preventWidows and disablePreventWidows from FormattedHeader

* Happiness support

* BackupGettingStarted

* JetpackProductCardFeaturesItem

* JetpackProductCard

* Jetpack backups

* Backup successful

* IntroPricingBanner

* JetpackDisconnected

* JetpackDisconnectedWPCOM

* LicensingActivation

* PurchaseDetail

* SeoPreviewNudge

* Add new site popover

* theme collection

* Update test snapshots

* Fix Storybook compilation in components package (#103362)

* Add conditionNames for Storybook Webpack build

* Editor: Stop preloading section (#103334)

* Editor: Stop preloading section

* Get rid of actionHoverCallback

* Breadcrumbs: Add `renderItemLink ` prop (#103321)

* SummaryButton: Add `renderLink` prop

* Rename to renderItemLink, split Item vs BreadcrumbsItemProps, refactor implementation

* Prevent flickering in Storybook when opning menu in compact mode

* Add open for extension to docs

* add a test and console.log in story

* feedback

---------

Co-authored-by: Marco Ciampini <[email protected]>

* Update different A4A labels to sentence case (#103238)

* Update different A4A labels to sentence case

* Fix one more occurence

* Showing multiple domain selection on new-hosted-site flow (#103359)

* E2E Auth: Fix apple login flow to wpcom and woo (#103357)

* Encript updated path

* E2E auth apple: fix wpcom and woo auth flows

* Follow up of #103321 (#103382)

* WooCoreProfilerMasterbar: fix useSelector and useTranslate usages (#103373)

* Fix/stop import redirect after failed wix (#103358)

* Redirect to the correct step when a wix migration fails

* remove hardcoded true

---------

Co-authored-by: Andrés Blanco <[email protected]>

* Notifications settings: change Publicized copy  (#103265)

* change copy for Jetpack Social notification setting (formerly Publicized)

* do not translate brand name

* Improves the design for the Migration Requested page (#103183)

* Improves the design for the Migration Requested page

* Remove card borders

* A4A: Fix the background color (#103389)

* Revert "Notifications settings: change Publicized copy  (#103265)" (#103392)

This reverts commit c320da3.

* Apps: Fix Odyssey translation extraction. (#103393)

* change Publicized copy to Jetpack Social brand, add translators comment (#103395)

* Fix e2e onboarding new hosted site tests (#103383)

* Upgrade importers to container v2 (#103024)

* Upgrade importers to container v2

* remove test string

* show title inside the import drag if not using container v2

* fix heading wp importer

* fix progressbar

* hacky but working

* apply Gabriel's suggestions

---------

Co-authored-by: Andrés Blanco <[email protected]>

* Apps: Fix Odyssey widget reactivity. (#103400)

* STATS-64: Don't dispatch legacy country data (#103376)

* STATS-67 - Don't navigate to the current tab if we are already on the current tab (#103379)

* STATS-67: Don't reload page if current tab is already the selected tab

* Add comment as to why the tab selected conditionally

* Stats: Fix styling on Odyssey Stats for Navigation Improvement (#103369)

* Fix main navigation mobile dropdown item padding

* Make mobile summary nav dropdown 100% width

* Fix Locations summary mobile item list label padding

* Fix stats-navigation tab selectors for tests

* Stats: Fix e2e tests by handling new selectors for the new nav header (#103384)

* Add a new utility function for clicking on new navigation

* Handle selectors for the new navigation header in e2e tests

* Don't update the selector for other tests apart from stats

* remove has-fixed-nav when new nav enabled

* avoid loading style conflicts

---------

Co-authored-by: Nikhil <[email protected]>
Co-authored-by: Dognose <[email protected]>
Co-authored-by: Dognose <[email protected]>
Co-authored-by: tellthemachines <[email protected]>
Co-authored-by: Andrew Duthie <[email protected]>
Co-authored-by: Marin Atanasov <[email protected]>
Co-authored-by: Nik Tsekouras <[email protected]>
Co-authored-by: Marco Ciampini <[email protected]>
Co-authored-by: Wojtek Naruniec <[email protected]>
Co-authored-by: Paulo Marcos Trentin <[email protected]>
Co-authored-by: Bogdan Nikolic <[email protected]>
Co-authored-by: Jarda Snajdr <[email protected]>
Co-authored-by: Andrés Blanco <[email protected]>
Co-authored-by: Andrés Blanco <[email protected]>
Co-authored-by: Christian Gastrell <[email protected]>
Co-authored-by: valterlorran <[email protected]>
Co-authored-by: arthur791004 <[email protected]>
Co-authored-by: sdnunca <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bogiii bogiii bogiii approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@paulopmt1 @matticbot @bogiii