Revert changes for loading state of magic login

[grzegorz-cp]

Reverting #102246

This reverts commit d7b83fa.

Related to ONBOARD-99

Proposed Changes

• revert changes made to loading state for magic login due to the changes in the technical approach

Why are these changes being made?

Testing Instructions

• create a JN site and start Jetpack connection for a user that is not logged in to wp.com
• when redirected to wp.com apply the URL to the live branch URL for this PR
• follow magic link login flow and verify that it works

Pre-merge Checklist

• Has the general commit checklist been followed? (PCYsg-hS-p2)
• Have you written new tests for your changes?
• Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
• Have you checked for TypeScript, React or other console errors?
• Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
• Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
• For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

[github-actions]

Calypso Live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-142347

Jetpack Cloud live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-142347&env=jetpack

Automattic for Agencies live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-142347&env=a8c-for-agencies

[matticbot]

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~126 bytes removed 📉 [gzipped])

name         parsed_size           gzip_size
entry-login       -564 B  (-0.0%)     -126 B  (-0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

[robertsreberski]

Thanks for working on it @grzegorz! I do believe, we also need to revert this code, that introduced ellipses in general: #102109

[grzegorz-cp]

Thanks for the reminder @robertsreberski. Some parts of that PR were already reverted but I removed the rest.

[manzoorwanijk]

This tests well

[tellthemachines]

Was the removal of this.renderLinks from here intended? The PR that this reverts only added the condition, so this change goes beyond the scope of a simple reversion.

[grzegorz-cp]

Thank you for finding this. I added a PR to restore the link.