-
Notifications
You must be signed in to change notification settings - Fork 2k
Purchase management: Correct DataViews table CSS #102711
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Purchase management: Correct DataViews table CSS #102711
Conversation
6ffed8e
to
1c3588f
Compare
d35b7bf
to
8977b93
Compare
Making a note: @sirbrillig pointed out in #102742 (comment) that the donation purchases are showing up below the DataViews table, rather than being included in it. Need to figure out why that is happening. UPDATE: Turns out this isn't CSS related, but rather the purchases being rendered outside of the original |
8977b93
to
cdcfdb0
Compare
@sirbrillig I think the CSS fixes for the DataViews table are ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks way better! Thanks!
There's one more thing I noticed while testing this (and maybe you already know), but it's not directly related to this PR: I think the table view has lost the ability to link to the single purchase view. This becomes particularly notable at mobile width due to horizontal scrolling.
Production | DataView | DataView scrolled |
---|---|---|
![]() |
![]() |
![]() |
Anyway, definitely not a blocker here. I'll mention it on #86616
Related to #
Proposed Changes
Active Upgrades
layout as possible.Production
DataViews PR
One specific change to note, since DataViews renders the fields in a true table format, we can no longer rely on flex to push the "status" column to the right and reduce its width. So when there are extremely long site titles or URLs, this PR has changed the CSS to hide the overflow. The other option is to break the string and wrap it on a new line.
Production: Shifts the "columns" to handle the longer string

DataViews PR: Hides the overflow

Another issue to highlight is that DataViews doesn't currently allow the column elements to wrap or stack in smaller screens. Our current production option allows the different
PurchasesItem
components to wrap in together. DataViews maintains the table view which can be scrolled left or right for the whole view.Why are these changes being made?
Active upgrades
list from the PurchasesSites component to DataViews, we have to account for styling changes now that the different payment elements are being rendered in a table format.Testing Instructions
me/purchases
Pre-merge Checklist