Skip to content

Site Migration: Transfer with software API, update hooks #102248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 1, 2025
Merged

Site Migration: Transfer with software API, update hooks #102248

merged 5 commits into from
Apr 1, 2025

Conversation

sixhours
Copy link
Contributor

@sixhours sixhours commented Mar 31, 2025 •
edited
Loading

Related to 178867-ghe-Automattic/wpcom

Proposed Changes

  • We recently made changes to the backend API, this updates the hooks' expected response types to match.

Why are these changes being made?

  • 178867-ghe-Automattic/wpcom

Testing Instructions

  • Tests should pass and visual inspection should be sufficient.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@sixhours sixhours requested a review from a team March 31, 2025 17:59
@sixhours sixhours self-assigned this Mar 31, 2025
@matticbot matticbot added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Mar 31, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 31, 2025 •
edited by matticbot
Loading

Calypso Live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-139309
Jetpack Cloud live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-139309&env=jetpack
Automattic for Agencies live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-139309&env=a8c-for-agencies

@sixhours sixhours added the [Feature] Site Migration Features related to site migrations to WPcom label Mar 31, 2025
@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@matticbot
Copy link
Contributor

matticbot commented Mar 31, 2025 •
edited
Loading

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • help-center

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/transfer-with-software-hooks on your sandbox.

valterlorran
valterlorran reviewed Apr 1, 2025
View reviewed changes
Copy link
Contributor

@valterlorran valterlorran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should make the siteID and the atomicTransferID on the useTransferWithSoftwareStatus query nullable. That's because usually the blogId will be nullable coming from the component, the same for the atomicTransferID, that will be available only when we create or fetch it.

https://github.com/Automattic/wp-calypso/pull/102248/files#diff-1fd1b55bd5a924fe0a46467ec79d4524015c050a12bb094501f45aa95a19153eL14-R12

valterlorran
valterlorran reviewed Apr 1, 2025
View reviewed changes
markbiek
markbiek approved these changes Apr 1, 2025
View reviewed changes
Copy link
Contributor

@markbiek markbiek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sixhours sixhours requested review from markbiek, valterlorran and a team April 1, 2025 18:49
valterlorran
valterlorran approved these changes Apr 1, 2025
View reviewed changes
Copy link
Contributor

@valterlorran valterlorran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for addressing the feedback 👍

@sixhours sixhours merged commit 8567e05 into trunk Apr 1, 2025
16 checks passed
@sixhours sixhours deleted the update/transfer-with-software-hooks branch April 1, 2025 19:21
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Apr 1, 2025
JessBoctor pushed a commit to JessBoctor/wp-calypso that referenced this pull request Apr 15, 2025
@sixhours @JessBoctor
Site Migration: Transfer with software API, update hooks (Automattic#…
a164c24 
…102248)

* Update query hook types and tests

* Remove unused response params

* use correct response type

* Make siteId and transferId nullable; update success => completed

* Account for potentially null values
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valterlorran valterlorran valterlorran approved these changes

@markbiek markbiek Awaiting requested review from markbiek

Assignees

@sixhours sixhours

Labels
[Feature] Site Migration Features related to site migrations to WPcom
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sixhours @matticbot @markbiek @valterlorran