RDV: Force treatment on Calypso without assigning users to the experiment

[rcrdortiz]

Related to:

• Remove the initial RDV hold-out experiment #101534

Proposed Changes

The RDV assignment is now always treated as treatment, though no real assignments are occurring anymore. The codebase will assume the user is in the Treatment group. This change effectively enables the feature by relying on existing logic while we clean up various locations where assignment checks are currently being performed.

Why are these changes being made?

We're moving forward with removing duplicate views and we need to remove/force everyone to the treatment group.

Testing Instructions

• Follow the testing instructions found here: RDV: Force treatment group for everyone on WPCom jetpack#42765

Pre-merge Checklist

• Has the general commit checklist been followed? (PCYsg-hS-p2)
• Have you written new tests for your changes?
• Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
• Have you checked for TypeScript, React or other console errors?
• Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
• Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
• For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

[github-actions]

Calypso Live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-139298

Jetpack Cloud live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-139298&env=jetpack

Automattic for Agencies live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-139298&env=a8c-for-agencies

[matticbot]

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~109 bytes removed 📉 [gzipped])

name         parsed_size           gzip_size
entry-main        -343 B  (-0.0%)     -109 B  (-0.0%)
entry-login       -343 B  (-0.0%)     -109 B  (-0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~50 bytes removed 📉 [gzipped])

name           parsed_size           gzip_size
staging-site        -107 B  (-0.0%)      -25 B  (-0.0%)
site-settings       -107 B  (-0.0%)      -25 B  (-0.0%)
hosting             -107 B  (-0.0%)      -25 B  (-0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

[matticbot]

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

• help-center
• notifications
• wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug add/return-rdv-treatment-for-all on your sandbox.

[xavier-lc]

For checking the bug...

• Open the Live link
• Go to {container}/sites/settings/database/{non-atomic site}
• You should not see the database feature page and should be redirected instead.

I can see the db feature:

Nevermind, I've seen now the latest commit and the new issue.

[rcrdortiz]

For checking the bug...

• Open the Live link
• Go to {container}/sites/settings/database/{non-atomic site}
• You should not see the database feature page and should be redirected instead.

I can see the db feature:

Nevermind, I've seen now the latest commit and the new issue.

I've updated the PR description so that we don't include the bugfix anymore.

[xavier-lc]

LGTM